Skip to content

fix:When use_spark = True and mlflow_logging = True are set, an error is reported when logging the best model: 'NoneType' object has no attribute 'save' bug Something isn't working#1432

Merged
thinkall merged 3 commits into
microsoft:mainfrom
hexiang-x:hx-issue1431
May 14, 2025

Conversation

@hexiang-x
Copy link
Copy Markdown
Contributor

fix:When use_spark = True and mlflow_logging = True are set, an error is reported when logging the best model: 'NoneType' object has no attribute 'save' bug Something isn't working)

Why are these changes needed?

When use_spark = True and mlflow_logging = True are set, an error is reported when logging the best model: 'NoneType' object has no attribute 'save' bug Something isn't working

Related issue number

#1431

Checks

…the best model has been trained and is not None
Copy link
Copy Markdown
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR, @hexiang-x ! LGTM.

@hexiang-x hexiang-x requested a review from thinkall May 14, 2025 07:03
@hexiang-x
Copy link
Copy Markdown
Contributor Author

hexiang-x commented May 14, 2025

@hexiang-x please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Tencent"

@hexiang-x
Copy link
Copy Markdown
Contributor Author

hexiang-x commented May 14, 2025

Thank you very much for the PR, @hexiang-x ! LGTM.

@thinkall Hi, The code is ready to be merged!

@thinkall thinkall merged commit 5107c50 into microsoft:main May 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants