Skip to content

Add the detailed info for parameter 'verbose'#1435

Merged
thinkall merged 10 commits into
mainfrom
mrl-verbose-0522
May 27, 2025
Merged

Add the detailed info for parameter 'verbose'#1435
thinkall merged 10 commits into
mainfrom
mrl-verbose-0522

Conversation

@murunlin
Copy link
Copy Markdown
Collaborator

@murunlin murunlin commented May 22, 2025

Why are these changes needed?

Add the detailed explanation for parameter 'verbose', which can control the logger level such as ERROR, WARNING messages.

Related issue number

Related to #1428

Checks

Copy link
Copy Markdown
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @murunlin. Could you add the logging level when verbose = 4, 5 and more? And make the description more concise. Thanks.

Copy link
Copy Markdown
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only (shows ERROR + CRITICAL) and (all messages)? I suggest remove both of them.

As I've tested, verbose 5 will not show all messages, but verbose > 5 will do. Please add info of verbose > 5.

Thanks.

Runlin Mu (FESCO Adecco Human Resources) added 3 commits May 23, 2025 01:22
Comment thread setup.py Outdated
Comment thread setup.py Outdated
Comment thread .github/workflows/python-package.yml Outdated
@thinkall thinkall merged commit 12183e5 into main May 27, 2025
29 of 31 checks passed
@thinkall thinkall deleted the mrl-verbose-0522 branch May 27, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants