Unpin Pydantic#1452
Conversation
|
@microsoft-github-policy-service agree company="Individual" |
|
@thinkall I'm not sure who to ping about this. Could you take a look? |
thinkall
left a comment
There was a problem hiding this comment.
Thank you very much for the PR. LGTM.
|
@thinkall It seems like older versions of ray[tune] are not compatible with pydantic v2. I bumped it to |
Hi @OlivierBinette-UpStart , ray 2 is not tested yet. Let's see will it work. |
|
In fact, pydantic is not pinned in FLAML. If you don't install ray[tune], you're good to go with any pydantic version. autogen module is not updated in FLAML for a long time, if you need autogen, checkout microsoft/autogen repo. @OlivierBinette-UpStart |
|
@thinkall Oh you're totally right. We're using ray[tune], which is where the Pydantic dependency must be coming from. Do you think FLAML can be compatible with newer versions of Ray? |
The latest PR for supporting ray is #1392, but I'm not sure will it work for other modules or not. I think some changes will be needed. |
|
Pydantic's version is no more limited. Close this PR. @OlivierBinette-UpStart , based on my initial test, ray 2 can work. Any bugs/PRs for better supporting ray 2 is very welcome! |
Why are these changes needed?
FLAMLcurrently uses a pinned version of Pydantic, version1.10.9. This makes it impossible to installFLAMLalongside libraries that use other versions of Pydantic or Pydantic v2.Unclear why that limitation is required. Pydantic is only imported in a single place within the whole of the package.
Changes:
pydanticto be compatible with both version 1 and version 2.Checks