Fix OSError: [Errno 24] Too many open files: 'nul'#1455
Merged
Conversation
Added closing of save_fds.
Sm1Ling
changed the title
Collaborator
|
Thank you so much for the PR, @Sm1Ling. Can you please fix the code format issue and the TypeError in the added code? Thanks. 
|
thinkall
requested changes
Aug 25, 2025
Collaborator
thinkall
left a comment
thinkall
left a comment
There was a problem hiding this comment.
Could you please fix the test errors? Thanks.
Updated model.py for pre-commit requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added closing of save_fds.
Why are these changes needed?
This change fixes bug mentioned in Issue #1454
Related issue number
Closes #1454
Checks
Actually, I haven't made any checks. Just fixed 2 lines of code