Skip to content

update loc second argument to column#1458

Merged
thinkall merged 1 commit into
microsoft:mainfrom
konabuta:patch-1
Aug 30, 2025
Merged

update loc second argument to column#1458
thinkall merged 1 commit into
microsoft:mainfrom
konabuta:patch-1

Conversation

@konabuta
Copy link
Copy Markdown
Contributor

Changed he second argument of the loc function to specify the column instead of DataFrame - X.

Why are these changes needed?

The current implement of loc funcion is specifing dataframe which causes error when dealing with duplicated dataframe.

Related issue number

N/A

Checks

Configure second args of loc function to time_col instead of dataframe - X.
@konabuta konabuta requested a review from Copilot August 27, 2025 13:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the time series duplicate detection logging where the loc function was incorrectly using the DataFrame as the second argument instead of the column name.

  • Fixed incorrect pandas loc indexing syntax in duplicate timestamp logging
  • Updated the warning message to properly display duplicate timestamp values

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@konabuta konabuta changed the title update loc second args - column update loc second argument to column Aug 27, 2025
@konabuta konabuta requested a review from thinkall August 27, 2025 13:51
Copy link
Copy Markdown
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you @konabuta for the PR!

@thinkall thinkall merged commit e191074 into microsoft:main Aug 30, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants