-
Notifications
You must be signed in to change notification settings - Fork 560
Add configurable label overlap handling for classification holdout strategy #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
43c857d
Initial plan
Copilot ea986ad
Fix training/test set overlap in holdout classification by only addin…
Copilot d114a01
Address code review feedback: add bounds checking and fix edge cases
Copilot 09366e9
Fix bounds checking: use correct comparison operator for array indexing
Copilot ef2bbf8
Fix potential ValueError with max() on empty lists and simplify test …
Copilot 4a1ddda
Add extra bounds checking for label_matches indices
Copilot 11787ce
Merge branch 'main' into copilot/fix-training-test-set-overlap
thinkall 1e832d8
Merge branch 'main' into copilot/fix-training-test-set-overlap
thinkall ee8a3aa
Fix pandas_on_spark compatibility by using iloc_pandas_on_spark util …
Copilot 53d8c20
Run pre-commit to fix formatting issues
Copilot 3c8421e
Improve missing label handling to avoid overlap when possible
Copilot 4d841d6
Fix: ensure at least 1 instance remains in original set when re-split…
Copilot a6f93c4
Merge branch 'main' into copilot/fix-training-test-set-overlap
thinkall 3750f7d
Merge branch 'main' into copilot/fix-training-test-set-overlap
thinkall b7e562b
Refactor: Extract missing label handling into two methods (fast/slow)
Copilot d96b8ff
Add usage example for allow_label_overlap to Best-Practices.md
Copilot 15205f7
Merge branch 'main' into copilot/fix-training-test-set-overlap
thinkall 8038a6a
Address code review feedback: update documentation and tests
Copilot d4c9525
Merge branch 'main' into copilot/fix-training-test-set-overlap
thinkall 5e0b138
Fix AttributeError: initialize _allow_label_overlap in settings and r…
Copilot b0efb54
Add docstring to fit()
thinkall File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.