Skip to content

feat: add py.typed marker for PEP 561 compliance #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kalichiruvelli-art wants to merge 3 commits into from
Closed

feat: add py.typed marker for PEP 561 compliance #1530

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d54e58
feat: add py.typed marker for PEP 561 compliance
kalichiruvelli-art Apr 20, 2026
cbd5e48
Merge branch 'main' into feat/add-py-typed-marker
thinkall Apr 27, 2026
7e76804
Merge branch 'main' into feat/add-py-typed-marker
thinkall Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,3 +211,6 @@ unfixable = ["F401"]
[tool.ruff.mccabe]
# Unlike Flake8, default to a complexity level of 10.
max-complexity = 10

[tool.setuptools.package-data]
flaml = ["py.typed"]
Comment on lines +215 to +216
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This [tool.setuptools.package-data] entry may not be applied in the current release/build pipeline, which runs python setup.py sdist bdist_wheel (see .github/workflows/CD.yml). Since setup.py currently only sets package_data for flaml.default, the built wheel may still omit flaml/py.typed, defeating the PEP 561 marker. Consider adding py.typed to package_data in setup.py (or switching packaging to a PEP 517/pyproject-based setuptools config) to ensure it is included in sdists/wheels.

Copilot uses AI. Check for mistakes.
Loading