Skip to content

fix: LRL1 results now reproducible #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thinkall merged 1 commit into from
May 12, 2026
+5 −2
Merged

fix: LRL1 results now reproducible #1546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flaml/automl/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2032,6 +2032,9 @@ def config2params(self, config: dict) -> dict:

def __init__(self, task="binary", **config):
super().__init__(task, **config)
random_seed = self.params.pop("random_seed", config.get("random_seed", 10242048))
if "random_state" not in self.params:
self.params["random_state"] = random_seed
assert self._task.is_classification(), "LogisticRegression for classification task only"
self.estimator_class = LogisticRegression

Expand Down
4 changes: 2 additions & 2 deletions test/automl/test_classification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ def test_sparse_matrix_lr(self):
"histgb",
"kneighbor",
"lgbm",
# "lrl1",
"lrl1",
"lrl2",
"rf",
"sgd",
Expand Down Expand Up @@ -495,7 +495,7 @@ def test_reproducibility_of_classification_models(estimator: str):
"histgb",
"kneighbor",
"lgbm",
# "lrl1",
"lrl1",
"lrl2",
"svc",
"rf",
Expand Down
Loading