fix: XGBoostSklearnEstimator honors random_seed config#1549
Open
immu4989 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Seed
random_stateonXGBoostSklearnEstimator.__init__soxgb.XGBClassifier/xgb.XGBRegressor/xgb.XGBRankerproduce deterministic results across runs and honor the FLAML-internalrandom_seedconfig. Uses the same defensive pattern as #1541 and #1546 , pop therandom_seedkey fromself.params, and only setrandom_statewhen the caller has not already provided one.XGBoostLimitDepthEstimatorinherits fromXGBoostSklearnEstimator, so this PR closes two of the remaining XGBoost items in tracking issue #1540 (the non-sklearnXGBoostEstimatorpath will be addressed in a follow up PR).Before this change, the existing
xgboost/xgb_limitdepthreproducibility tests passed only because the search space init values (subsample=1.0,colsample_bytree=1.0,colsample_bylevel=1.0) are themselves deterministic. A different dataset ormax_iterthat explored stochastic-subsample configs would not have been reproducible.Related issue number
Tracking issue: #1540
Pattern reference: #1547 (RandomForest), #1541 (SGD), #1546 (LRL1)
Checks