Update cache check (#591)

Author: linglingye001

src/Microsoft.FeatureManagement/ConfigurationFeatureDefinitionProvider.cs

@@ -17,11 +17,8 @@ namespace Microsoft.FeatureManagement
     /// <summary>
     /// A feature definition provider that pulls feature definitions from the .NET Core <see cref="IConfiguration"/> system.
     /// </summary>
-    public sealed class ConfigurationFeatureDefinitionProvider : IFeatureDefinitionProvider, IDisposable, IFeatureDefinitionProviderCacheable
+    public sealed class ConfigurationFeatureDefinitionProvider : IFeatureDefinitionProvider, IDisposable
     {
-        //
-        // IFeatureDefinitionProviderCacheable interface is only used to mark this provider as cacheable. This allows our test suite's
-        // provider to be marked for caching as well.
         private readonly IConfiguration _configuration;
         private readonly ConfigurationFeatureDefinitionProviderOptions _options;
         private IEnumerable<IConfigurationSection> _dotnetFeatureDefinitionSections;

src/Microsoft.FeatureManagement/FeatureManager.cs

@@ -681,7 +681,7 @@ private void BindSettings(IFeatureFilterMetadata filter, FeatureFilterEvaluation
                 return;
             }
 
-            if (!(_featureDefinitionProvider is IFeatureDefinitionProviderCacheable) || Cache == null)
+            if (!(context.Parameters is ConfigurationWrapper) || Cache == null)
             {
                 context.Settings = binder.BindParameters(context.Parameters);
 

src/Microsoft.FeatureManagement/IFeatureDefinitionProviderCacheable.cs

@@ -967,10 +967,10 @@ public async Task BindsFeatureFlagSettings()
             FeatureFilterConfiguration testFilterConfiguration = new FeatureFilterConfiguration
             {
                 Name = "Test",
-                Parameters = new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string, string>()
+                Parameters = new ConfigurationWrapper(new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string, string>()
                 {
                     { "P1", "V1" },
-                }).Build()
+                }).Build())
             };
 
             var services = new ServiceCollection();
@@ -1039,7 +1039,7 @@ public async Task BindsFeatureFlagSettings()
 
             //
             // Cache break.
-            testFilterConfiguration.Parameters = new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string, string>()).Build();
+            testFilterConfiguration.Parameters = new ConfigurationWrapper(new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string, string>()).Build());
 
             binderCalled = false;
 

tests/Tests.FeatureManagement/FeatureManagementTest.cs

@@ -6,7 +6,7 @@
 
 namespace Tests.FeatureManagement
 {
-    class InMemoryFeatureDefinitionProvider : IFeatureDefinitionProvider, IFeatureDefinitionProviderCacheable
+    class InMemoryFeatureDefinitionProvider : IFeatureDefinitionProvider
     {
         private IEnumerable<FeatureDefinition> _definitions;