Consolidate ParametersObject into Settings on FeatureFilterEvaluationContext#599
Merged
zhiyuanliang-ms merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
…ttings. Co-authored-by: Copilot <copilot@github.com>
zhiyuanliang-ms
approved these changes
Apr 23, 2026
zhiyuanliang-ms
added a commit
that referenced
this pull request
Apr 23, 2026
* Remove FeatureFilterEvaluationContext.ParametersObject in favor of Settings. (#599) Co-authored-by: Copilot <copilot@github.com> * Skip parameter binding if ParamemtersObject provided (#597) * Skip parameter binding if the provider has already supplied a parameters object * update * update --------- Co-authored-by: Zhiyuan Liang <zhiyuanliang@microsoft.com> --------- Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: linglingye001 <143174321+linglingye001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the ParametersObject property from FeatureFilterEvaluationContext and unifies its functionality into the existing Settings property.
Motivation
ParametersObject and Settings served overlapping roles on the evaluation context — both carried a pre-resolved settings object for filters. Consolidating them into a single property simplifies the API surface and the fallback logic in
Changes:
FeatureFilterEvaluationContext: Removed ParametersObject. The Settings property now serves both purposes — receiving pre-provided parameter objects (via FeatureFilterConfiguration.ParametersObject) and pre-bound settings from IFilterParametersBinder.FeatureManager: Assigns FeatureFilterConfiguration.ParametersObject directly to Settings on the evaluation context. Skips BindSettings when Settings is already populated.