feat(tree): no-commit option on applyChange#27665
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (91 lines, 6 files), I've queued these reviewers:
How this works
|
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
| * @param generateCommit - whether to generate a commit for this change. Defaults to true. | ||
| * Typically set to false when applying the net change corresponding to a rebase. |
There was a problem hiding this comment.
What do we mean by "generate a commit" here? This isn't immediately clear to me. Might be worth expanding on that here and/or expanding on the rebase example.
There was a problem hiding this comment.
Based on the tests below, this seems to be whether or not we emit change events in response to the applied change? If so, I think we should clarify that here.
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
Description
Adds an optional parameter to
TreeBranchAlpha.applyChangethat makes it possible not to generate a commit for the applied change. This makes sense when the change being applied does not correspond to a real commit but instead correspond to rebase.This is used in #27649.
Breaking Changes
None