refactor

Author: Raja Phanindra Chava

sdk/cpp/src/openai_embedding_client.cpp

@@ -20,7 +20,6 @@ namespace foundry_local {
 
     namespace {
         /// True for strings that are empty or contain only whitespace characters.
-        /// Equivalent to C#'s IsNullOrWhiteSpace, JS's trim() === '', Python's .strip() == "".
         bool IsBlank(std::string_view s) {
             for (char c : s) {
                 if (!std::isspace(static_cast<unsigned char>(c))) {

sdk/python/src/openai/embedding_client.py

@@ -98,7 +98,7 @@ def generate_embeddings(self, inputs: List[str]) -> CreateEmbeddingResponse:
             ValueError: If *inputs* is empty or contains empty strings.
             FoundryLocalException: If the underlying native embeddings command fails.
         """
-        if not inputs or len(inputs) == 0:
+        if not inputs:
             raise ValueError("Inputs must be a non-empty list of strings.")
 
         for text in inputs:

sdk/rust/src/openai/embedding_client.rs

@@ -55,27 +55,23 @@ impl EmbeddingClient {
             .execute_command_async("embeddings".into(), Some(params))
             .await?;
 
-        // Patch the response to add fields required by async_openai types
-        // that the server doesn't return (object on each item, usage)
+        // The server omits two fields that async_openai's CreateEmbeddingResponse
+        // requires: per-item `object` and top-level `usage`. Inject defaults before
+        // deserializing.
         let mut response_value: Value = serde_json::from_str(&raw)?;
         if let Some(data) = response_value
             .get_mut("data")
             .and_then(|d| d.as_array_mut())
         {
             for item in data {
-                if item.get("object").is_none() {
-                    item.as_object_mut()
-                        .map(|m| m.insert("object".into(), json!("embedding")));
+                if let Some(obj) = item.as_object_mut() {
+                    obj.entry("object").or_insert_with(|| json!("embedding"));
                 }
             }
         }
-        if response_value.get("usage").is_none() {
-            response_value.as_object_mut().map(|m| {
-                m.insert(
-                    "usage".into(),
-                    json!({"prompt_tokens": 0, "total_tokens": 0}),
-                )
-            });
+        if let Some(root) = response_value.as_object_mut() {
+            root.entry("usage")
+                .or_insert_with(|| json!({"prompt_tokens": 0, "total_tokens": 0}));
         }
 
         let parsed: CreateEmbeddingResponse = serde_json::from_value(response_value)?;