Commit d505aef
Fix issues from PR #613 review feedback
- Fix start() holding mutex across FFI call: release lock before
native core call, add 'starting' transitional state to prevent
concurrent start() races (mirrors Rust PR feedback about
mutex-across-channel-send deadlock)
- Remove codex.md review artifact from repo (reviewer feedback)
- Expose active_settings() getter for frozen settings snapshot
- Break stop() into drain_push_queue_and_thread(), send_native_stop(),
enqueue_final_result() helpers for readability
- Improve error messages with more context
- Add 2 new tests: StartError_RevertsToNotStarted_CanRetry,
ActiveSettings_ExposedAfterStart
- Update SettingsFrozenAfterStart test to verify via active_settings()
- All 62 tests passing (59 unit + 3 E2E)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 3a11f3c commit d505aef
4 files changed
Lines changed: 173 additions & 193 deletions
File tree
- sdk/cpp
- include/foundry_local
- src
- tests
This file was deleted.
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
102 | 106 | | |
103 | | - | |
| 107 | + | |
104 | 108 | | |
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
108 | 117 | | |
109 | 118 | | |
110 | 119 | | |
| |||
114 | 123 | | |
115 | 124 | | |
116 | 125 | | |
117 | | - | |
| 126 | + | |
118 | 127 | | |
119 | 128 | | |
120 | 129 | | |
| |||
0 commit comments