Skip to content

adds support for netstandard2.0#629

Merged
prathikr merged 72 commits intomainfrom
prathikrao/net8-support
Apr 23, 2026
Merged

adds support for netstandard2.0#629
prathikr merged 72 commits intomainfrom
prathikrao/net8-support

Conversation

@prathikr
Copy link
Copy Markdown
Contributor

@prathikr prathikr commented Apr 14, 2026

@prathikr prathikr changed the title adds support for .NET 8.0 adds support for netstandard2.0 Apr 21, 2026
@prathikr prathikr requested a review from skottmckay April 21, 2026 21:44
Comment thread sdk/cs/src/Detail/ICoreInterop.cs Outdated
Comment thread sdk/cs/src/Detail/ModelLoadManager.cs
Comment thread sdk/cs/src/Configuration.cs
Comment thread sdk/cs/src/Microsoft.AI.Foundry.Local.csproj
Comment thread sdk/cs/src/Microsoft.AI.Foundry.Local.csproj
Comment thread sdk/cs/test/FoundryLocal.Tests/Microsoft.AI.Foundry.Local.Tests.csproj Outdated
@prathikr
Copy link
Copy Markdown
Contributor Author

prathikr commented Apr 22, 2026

Needed to apply some fixes for netstandard2.0

  1. the string.IsNullOrEmpty() guard ensures non-null, but the netstandard2.0 nullable annotations don't narrow the type.
  2. the CancellationToken overload doesn't exist in netstandard2.0's HttpContent
  3. WinML does not support netstandard2.0, they require minimum net8.0

skottmckay
skottmckay previously approved these changes Apr 23, 2026
Copy link
Copy Markdown
Member

@scottaddie scottaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As communicated via Teams:

Comment thread sdk/cs/src/Microsoft.AI.Foundry.Local.csproj
@prathikr prathikr merged commit 857aa22 into main Apr 23, 2026
47 checks passed
@prathikr prathikr deleted the prathikrao/net8-support branch April 23, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants