Conversation
|
👋 Thanks for contributing @PabloNunes! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
Updates the repository’s dev container configurations to use more general base image tags and standardized feature references, aiming to address GitHub Codespaces container creation/recovery-mode failures.
Changes:
- Switched devcontainer base images from a pinned .NET 10 tag to an untagged
mcr.microsoft.com/devcontainers/dotnetreference. - Replaced the previous ad-hoc
sshdentry with the officialghcr.io/devcontainers/features/sshd:1feature. - Normalized JSON formatting/indentation and minor command string cleanup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.devcontainer/devcontainer.json |
Moves to unpinned dotnet base image; adjusts feature entries (notably sshd) and formatting. |
.devcontainer/Ollama/devcontainer.json |
Same base image change for Ollama container; keeps Ollama pulls and aligns feature entries/formatting. |
Comments suppressed due to low confidence (2)
.devcontainer/devcontainer.json:14
- Issue reports mention Codespaces failing specifically while installing the Azure Developer CLI feature. This PR keeps the same
ghcr.io/azure/azure-dev/azd:0feature reference; if that feature version is the one hitting the download/arch issue, the Codespaces recovery-mode error may persist. Consider updating the azd feature reference to the currently supported major version (and/or pinning to a known-good azd version) so the container build is deterministic and aligned with the reported failure mode.
"ghcr.io/azure/azure-dev/azd:0": {
"version": "stable"
},
.devcontainer/Ollama/devcontainer.json:14
- If the Codespaces build failure is due to the azd devcontainer feature download path/architecture handling (as in the linked issue logs), this file also keeps the same
ghcr.io/azure/azure-dev/azd:0feature reference. Consider updating to the currently supported major version of the feature and/or pinning to a known-good azd release to reduce the chance of Codespaces entering recovery mode.
"ghcr.io/azure/azure-dev/azd:0": {
"version": "stable"
},
| "name": "C# (.NET)", | ||
| "image": "mcr.microsoft.com/devcontainers/dotnet:1-10.0-noble", | ||
| "name": "C# (.NET)", | ||
| "image": "mcr.microsoft.com/devcontainers/dotnet", |
There was a problem hiding this comment.
The dev container is described in AGENTS.md as “Default: .NET 10…”. Switching the base image to mcr.microsoft.com/devcontainers/dotnet (implicit :latest) removes the guarantee that the container will stay on .NET 10 and can break the repo as the tag advances (e.g., to .NET 11/12). Consider pinning to a .NET 10 tag again (e.g., the previous .../dotnet:1-10.0-noble or another explicit 10.0 tag) for reproducible Codespaces environments.
This issue also appears on line 12 of the same file.
| "image": "mcr.microsoft.com/devcontainers/dotnet", | |
| "image": "mcr.microsoft.com/devcontainers/dotnet:1-10.0-noble", |
There was a problem hiding this comment.
Noble is currently breaking as it is the main issue with Yarn GPG sinagure
| "name": "C# (.NET) - Ollama", | ||
| "image": "mcr.microsoft.com/devcontainers/dotnet:1-10.0-noble", | ||
| "name": "C# (.NET) - Ollama", | ||
| "image": "mcr.microsoft.com/devcontainers/dotnet", |
There was a problem hiding this comment.
Same as the default devcontainer: using mcr.microsoft.com/devcontainers/dotnet without a tag relies on :latest, which can silently move off .NET 10 over time. Since the course/repo targets .NET 10+, consider pinning this Ollama devcontainer to a .NET 10 tag as well for reproducible Codespaces builds.
This issue also appears on line 12 of the same file.
| "image": "mcr.microsoft.com/devcontainers/dotnet", | |
| "image": "mcr.microsoft.com/devcontainers/dotnet:10.0", |
There was a problem hiding this comment.
Noble is currently breaking as it is the main issue with Yarn GPG signature
Updating the dev container configuration files to use more general and consistent image tags and feature references.