azure-kubernetes: add VPA and pod rightsizing routing triggers (#2391)

* azure-kubernetes: add VPA and pod rightsizing routing triggers

The integration test 'invokes azure-kubernetes skill for pod
rightsizing prompt' has been flaky (0.2 invocation rate vs 0.8
threshold). The prompt 'Rightsize AKS pod resource requests/limits
using VPA recommendations' was routing to azure-compute or
azure-documentation in 4 of 5 runs because the azure-kubernetes
WHEN clause did not list the specific VPA and pod-resource
vocabulary that the prompt uses.

Add explicit triggers so routing is deterministic:

  - rightsize AKS pods (plural)
  - pod rightsizing
  - over-provisioned pods
  - pod resource requests and limits
  - container CPU and memory requests
  - Vertical Pod Autoscaler, VPA, VPA recommendations
  - kubectl top pods

No terms are removed; azure-compute already does not mention AKS,
pods, or rightsizing, so there is no collision to clear on that
side. The change only sharpens azure-kubernetes' WHEN clause.

Refs: #2372

* Trim AKS triggers to fit char budget; update snapshot

The previous revision pushed the formatted skill description total
over the 20000-char Copilot CLI budget by 54 chars and stale-dated
the triggers snapshot. This change:

- Drops the lower-value duplicate phrasing (the singular form
  'rightsize AKS pod' is already covered by the plural; 'container
  CPU and memory requests' is covered by 'pod resource requests
  and limits'; 'VPA' and 'kubectl top pods' are redundant with
  'Vertical Pod Autoscaler' and 'over-provisioned pods').
- Refreshes tests/azure-kubernetes/__snapshots__/triggers.test.ts.snap
  for the new description text and the new extracted keywords
  (autoscaler, limits, over-provisioned, pods, recommendations,
  requests, resource, rightsizing, vertical).

Refs: #2372

* Drop plural 'pods' keyword to preserve anti-trigger test

The previous push added 'pods' (plural) to azure-kubernetes' WHEN
clause. The triggers test extracts every word > 3 chars from the
description as a keyword, so 'pods' became a routable token. That
broke the anti-trigger assertion for the prompt 'Troubleshoot why
pods in my AKS cluster are crashlooping', which is meant to route
to azure-diagnostics — with both 'aks' and 'pods' matching, the
two-keyword threshold tripped.

Use the singular 'pod' everywhere in the description. The keyword
extractor filters words of length <= 3 (apart from a hardcoded
'ai' exception), so 'pod' contributes no new routing token, while
the human-readable triggers still cover the VPA / rightsizing
prompts the integration tests exercise. Replace 'over-provisioned
pods' with 'over-provisioned AKS pod' so the phrase still reads
naturally without the plural.

Snapshot updated to match (description text refreshed, 'pods'
removed from both keyword arrays).

Refs: #2372

Author: gambtho

plugin/skills/azure-kubernetes/SKILL.md

@@ -4,7 +4,7 @@ license: MIT
 metadata:
   author: Microsoft
   version: "0.0.0-placeholder"
-description: "Plan, create, and configure production-ready Azure Kubernetes Service (AKS) clusters. Covers Day-0 checklist, SKU selection (Automatic vs Standard), networking options (private API server, Azure CNI Overlay, egress configuration), security, and operations (autoscaling, upgrade strategy, cost analysis). WHEN: create AKS environment, provision AKS environment, enable AKS observability, design AKS networking, choose AKS SKU, secure AKS, optimize AKS, rightsize AKS pod, AKS spot nodes, AKS cluster-autoscaler."
+description: "Plan, create, and configure production-ready Azure Kubernetes Service (AKS) clusters. Covers Day-0 checklist, SKU selection (Automatic vs Standard), networking options (private API server, Azure CNI Overlay, egress configuration), security, and operations (autoscaling, upgrade strategy, cost analysis). WHEN: create AKS environment, provision AKS, enable AKS observability, design AKS networking, choose AKS SKU, secure AKS, optimize AKS, AKS spot nodes, AKS cluster-autoscaler, rightsize AKS pod, pod rightsizing, over-provisioned AKS pod, pod resource requests and limits, Vertical Pod Autoscaler, VPA recommendations."
 ---
 
 # Azure Kubernetes Service

tests/azure-kubernetes/__snapshots__/triggers.test.ts.snap

@@ -2,11 +2,12 @@
 
 exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill description triggers match snapshot 1`] = `
 {
-  "description": "Plan, create, and configure production-ready Azure Kubernetes Service (AKS) clusters. Covers Day-0 checklist, SKU selection (Automatic vs Standard), networking options (private API server, Azure CNI Overlay, egress configuration), security, and operations (autoscaling, upgrade strategy, cost analysis). WHEN: create AKS environment, provision AKS environment, enable AKS observability, design AKS networking, choose AKS SKU, secure AKS, optimize AKS, rightsize AKS pod, AKS spot nodes, AKS cluster-autoscaler.",
+  "description": "Plan, create, and configure production-ready Azure Kubernetes Service (AKS) clusters. Covers Day-0 checklist, SKU selection (Automatic vs Standard), networking options (private API server, Azure CNI Overlay, egress configuration), security, and operations (autoscaling, upgrade strategy, cost analysis). WHEN: create AKS environment, provision AKS, enable AKS observability, design AKS networking, choose AKS SKU, secure AKS, optimize AKS, AKS spot nodes, AKS cluster-autoscaler, rightsize AKS pod, pod rightsizing, over-provisioned AKS pod, pod resource requests and limits, Vertical Pod Autoscaler, VPA recommendations.",
   "extractedKeywords": [
     "aks",
     "analysis",
     "automatic",
+    "autoscaler",
     "autoscaling",
     "azure",
     "checklist",
@@ -32,6 +33,7 @@ exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill descri
     "identity",
     "key vault",
     "kubernetes",
+    "limits",
     "mcp",
     "monitor",
     "networking",
@@ -40,12 +42,17 @@ exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill descri
     "operations",
     "optimize",
     "options",
+    "over-provisioned",
     "overlay",
     "plan",
     "private",
     "production-ready",
     "provision",
+    "recommendations",
+    "requests",
+    "resource",
     "rightsize",
+    "rightsizing",
     "secure",
     "security",
     "selection",
@@ -55,6 +62,7 @@ exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill descri
     "standard",
     "strategy",
     "upgrade",
+    "vertical",
     "vnet",
     "when",
   ],
@@ -67,6 +75,7 @@ exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill keywor
   "aks",
   "analysis",
   "automatic",
+  "autoscaler",
   "autoscaling",
   "azure",
   "checklist",
@@ -92,6 +101,7 @@ exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill keywor
   "identity",
   "key vault",
   "kubernetes",
+  "limits",
   "mcp",
   "monitor",
   "networking",
@@ -100,12 +110,17 @@ exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill keywor
   "operations",
   "optimize",
   "options",
+  "over-provisioned",
   "overlay",
   "plan",
   "private",
   "production-ready",
   "provision",
+  "recommendations",
+  "requests",
+  "resource",
   "rightsize",
+  "rightsizing",
   "secure",
   "security",
   "selection",
@@ -115,6 +130,7 @@ exports[`azure-kubernetes - Trigger Tests Trigger Keywords Snapshot skill keywor
   "standard",
   "strategy",
   "upgrade",
+  "vertical",
   "vnet",
   "when",
 ]