azure-upgrade, replace personal repo in integration test with repos under well-known orgs by XiaofeiCao · Pull Request #2608 · microsoft/GitHub-Copilot-for-Azure

XiaofeiCao · 2026-06-09T07:07:06Z

Replaces the personal weidongxu-microsoft/java-update-examples repo in tests/azure-upgrade/integration.test.ts with the three well-known repos. Each entry is pinned to the latest commit on its default branch for reproducibility.

Changes

Scenario	Old (folder in java-update-examples)	New upstream (pinned)
File-based Azure auth -> `DefaultAzureCredential`	`azure-legacy-sdk-update-azure-client-initialization`	`Azure-Samples/aad-java-manage-service-principals` @ `83b4460`
EventProcessorHost `InMemory*` -> `BlobCheckpointStore`	`azure-legacy-sdk-update-eventhubs-v3`	`logstash-plugins/logstash-input-azure_event_hubs` @ `4a05eea` (sparse: `.ci/integration/event_hub_consumer`)
Batch `defineNewApplicationPackage` -> `applicationPackages().define()`	`azure-legacy-sdk-update-batch-java-manage-batch-accounts`	`Azure-Samples/batch-java-manage-batch-accounts` @ `105a076`

runJavaMigration now takes a { repoUrl, commitId, sparseCheckoutPath? } config and only adds the ""project can be found under ..."" hint when a sparse subpath is used.

Test results

All three java-sdk-migration-e2e tests pass against the new baselines:

migrates legacy file-based Azure auth (client init) to DefaultAzureCredential -> pass
migrates EventProcessorHost InMemory managers to BlobCheckpointStore -> pass
migrates Batch defineNewApplicationPackage chain to applicationPackages().define() -> pass

Migration assertions and skill-invocation tests are unchanged.

…e repos Replace the single weidongxu-microsoft/java-update-examples baseline with three pinned upstream repos so the migration assertions exercise the original Azure sample code: - file-based auth -> Azure-Samples/aad-java-manage-service-principals - EventProcessorHost -> logstash-plugins/logstash-input-azure_event_hubs (sparse checkout of .ci/integration/event_hub_consumer) - Batch defineNewApplicationPackage -> Azure-Samples/batch-java-manage-batch-accounts runJavaMigration now takes a { repoUrl, commitId, sparseCheckoutPath? } config and only adds the 'project can be found under ...' hint to the prompt when a sparse subpath is used. All three java-sdk-migration-e2e tests pass against the new baselines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Azure upgrade integration tests to use scenario-specific upstream sample repositories pinned to fixed commits, improving determinism while supporting repos whose Java sample lives in a subdirectory.

Changes:

Replaced the single shared samples repo with per-scenario repo/commit configurations.
Refactored runJavaMigration to accept a repo config object and handle optional sparseCheckoutPath.
Updated the affected tests to call runJavaMigration with the new configs.

weidongxu-microsoft · 2026-06-11T01:49:01Z

+const EVENT_PROCESSOR_HOST_REPO = {
+  repoUrl: "https://github.com/logstash-plugins/logstash-input-azure_event_hubs.git",
+  commitId: "4a05eea79342f1d451162d1a3e26270f6a484b4f",
+  // The Java sample lives in a subdirectory of this primarily-Ruby repo.
+  sparseCheckoutPath: ".ci/integration/event_hub_consumer",
+} as const;


nit, this is not our org?

No. I assume logstash-plugins be well-known org, and will not be removed any time sooner.

JasonYeMSFT · 2026-06-15T21:38:05Z

FYI, we are migrating testing from old integration tests to vally eval suites. Here is a PR converting azure-upgrade test cases. Could you please help review and merge the migration PR and then apply these changes to the vally eval suites?
#2648

…l-known-org-for-test

…or-test

JasonYeMSFT · 2026-06-24T16:13:28Z

@@ -0,0 +1,404 @@
+/**


Could you delete this file? We no longer run js tests for azure-upgrade in our scheduled tests.

jongio

Two issues in eval.yaml need fixing:

git clone --depth 1 --sparse is used for aad-java-manage-service-principals and batch-java-manage-batch-accounts, but no git sparse-checkout set follows. The default sparse-checkout cone only materializes root-level files. Both repos keep their Java sources under src/, so those files won't be checked out. This likely explains the failing eval CI check. Drop --sparse from these two clone commands (keep it for the logstash repo that genuinely uses sparse checkout).
The bare cd repo-name lines (254, 365) are no-ops left over from when git sparse-checkout set was chained there. Remove them or fold the fetch into that line.

Separately, @JasonYeMSFT flagged that integration tests are migrating to eval suites and asked to delete tests/azure-upgrade/integration.test.ts. That should be resolved before merging.

jongio · 2026-06-25T00:20:03Z

-        - git clone --depth 1 --sparse https://github.com/weidongxu-microsoft/java-update-examples.git
-        - cd java-update-examples && git sparse-checkout set azure-legacy-sdk-update-azure-client-initialization
-        - cd java-update-examples && git fetch --depth 1 origin 6d071296df8929482b0903241a23713a0bb952a4 && git checkout 6d071296df8929482b0903241a23713a0bb952a4
+        - git clone --depth 1 --sparse https://github.com/Azure-Samples/aad-java-manage-service-principals.git


--sparse enables sparse-checkout mode but no git sparse-checkout set follows. The default cone pattern only materializes root-level files. I checked the repo tree at this commit and Java sources live under src/, so they won't be checked out.

Drop --sparse since this repo doesn't need sparse checkout:

Suggested change

- git clone --depth 1 --sparse https://github.com/Azure-Samples/aad-java-manage-service-principals.git

- git clone --depth 1 https://github.com/Azure-Samples/aad-java-manage-service-principals.git

Same fix needed on line 364 for batch-java-manage-batch-accounts.

jongio · 2026-06-25T00:20:04Z

-        - cd java-update-examples && git sparse-checkout set azure-legacy-sdk-update-azure-client-initialization
-        - cd java-update-examples && git fetch --depth 1 origin 6d071296df8929482b0903241a23713a0bb952a4 && git checkout 6d071296df8929482b0903241a23713a0bb952a4
+        - git clone --depth 1 --sparse https://github.com/Azure-Samples/aad-java-manage-service-principals.git
+        - cd aad-java-manage-service-principals


This bare cd is a no-op. The next command already starts with cd aad-java-manage-service-principals && ..., so this line does nothing. It was meaningful before when git sparse-checkout set was chained here.

Remove it (same for line 365):

Suggested change

- cd aad-java-manage-service-principals

- cd aad-java-manage-service-principals && git fetch --depth 1 origin 83b446085a7ef35cf26b6d36255aa833aeb287bb && git checkout 83b446085a7ef35cf26b6d36255aa833aeb287bb

Dismissing: this review was incorrectly posted as changes-requested due to an automation bug. The findings remain valid as comments.

jongio

The eval CI check is failing. The likely root cause: --sparse is passed to git clone for aad-java-manage-service-principals (line 252) and batch-java-manage-batch-accounts (line 363), but no git sparse-checkout set follows either clone. The default sparse-checkout cone only materializes root-level files, so src/ (where the Java sources live) won't be checked out.

Fix: drop --sparse from those two clones. The logstash repo correctly uses sparse checkout because it chains git sparse-checkout set .ci/integration/event_hub_consumer on the next line.

Lines 253 and 364 (cd <repo-name>) are also no-ops. The subsequent command already starts with cd <repo-name> && ..., making the standalone cd redundant. Remove both lines.

Separately: @JasonYeMSFT asked to delete tests/azure-upgrade/integration.test.ts since integration tests are migrating to eval suites (see #2648). This PR adds a 404-line version of that file. Please resolve that conflict before merging.

jongio · 2026-06-26T23:49:47Z

@@ -250,9 +250,9 @@ stimuli:
        - "Continue with recommended options until complete."
    environment:
      commands:


--sparse enables sparse-checkout mode but no git sparse-checkout set follows. The default cone pattern only materializes root-level files. Java sources live under src/, so they won't be checked out. This is likely why the eval CI check is failing.

Drop --sparse since this repo doesn't need sparse checkout:

Suggested change

commands:

- git clone --depth 1 https://github.com/Azure-Samples/aad-java-manage-service-principals.git

jongio · 2026-06-26T23:49:47Z

@@ -361,9 +361,9 @@ stimuli:
        - "Continue with recommended options until complete."
    environment:
      commands:


Same issue here: --sparse without a subsequent git sparse-checkout set means src/ won't be checked out.

Suggested change

commands:

- git clone --depth 1 https://github.com/Azure-Samples/batch-java-manage-batch-accounts.git

jongio

One new nit since my last review (trailing underscore in the describe block name). My prior eval.yaml inline comments about --sparse without sparse-checkout set and no-op cd lines remain unresolved and are the likely cause of the failing eval CI check.

jongio · 2026-06-27T22:33:52Z

+          return (navigated && surfaced) || getToolCalls(m).length > 30;
+        }
+      });
+


Trailing underscore in the describe block name: the suite reports as azure-upgrade_ - Integration Tests.

Suggested change

describeIntegration(`${SKILL_NAME} - Integration Tests`, () => {

XiaofeiCao marked this pull request as ready for review June 9, 2026 07:20

Copilot AI review requested due to automatic review settings June 9, 2026 07:20

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread tests/azure-upgrade/integration.test.ts

Comment thread tests/azure-upgrade/integration.test.ts

XiaofeiCao changed the title ~~test(azure-upgrade): point java migration e2e tests at upstream sample repos~~ azure-upgrade, replace personal repo in integration test with repos under well-known orgs Jun 9, 2026

weidongxu-microsoft reviewed Jun 11, 2026

View reviewed changes

weidongxu-microsoft approved these changes Jun 11, 2026

View reviewed changes

XiaofeiCao and others added 3 commits June 24, 2026 16:01

Merge remote-tracking branch 'origin/main' into azure-upgrade/use-wel…

2d9b6cc

…l-known-org-for-test

apply change after switching to vally

26ff0b6

Merge branch 'microsoft:main' into azure-upgrade/use-well-known-org-f…

f65f616

…or-test

JasonYeMSFT reviewed Jun 24, 2026

View reviewed changes

jongio previously requested changes Jun 25, 2026

View reviewed changes

jongio reviewed Jun 26, 2026

View reviewed changes

jongio reviewed Jun 27, 2026

View reviewed changes

	- git clone --depth 1 --sparse https://github.com/Azure-Samples/aad-java-manage-service-principals.git
	- git clone --depth 1 https://github.com/Azure-Samples/aad-java-manage-service-principals.git

	- cd aad-java-manage-service-principals
	- cd aad-java-manage-service-principals && git fetch --depth 1 origin 83b446085a7ef35cf26b6d36255aa833aeb287bb && git checkout 83b446085a7ef35cf26b6d36255aa833aeb287bb

	commands:
	- git clone --depth 1 https://github.com/Azure-Samples/aad-java-manage-service-principals.git


	describeIntegration(`${SKILL_NAME} - Integration Tests`, () => {

Uh oh!

Conversation

XiaofeiCao commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Test results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

weidongxu-microsoft Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

XiaofeiCao Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

JasonYeMSFT commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JasonYeMSFT Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

jongio left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jongio Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jongio Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

jongio left a comment

Choose a reason for hiding this comment

Uh oh!

jongio Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

jongio Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

jongio left a comment

Choose a reason for hiding this comment

Uh oh!

jongio Jun 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

XiaofeiCao commented Jun 9, 2026 •

edited

Loading

JasonYeMSFT commented Jun 15, 2026 •

edited

Loading

jongio left a comment •

edited

Loading

jongio Jun 25, 2026 •

edited

Loading