Skip to content

azure-upgrade, replace personal repo in integration test with repos under well-known orgs #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XiaofeiCao wants to merge 4 commits into
base: main
Choose a base branch
from
+416 −12
Open

azure-upgrade, replace personal repo in integration test with repos under well-known orgs #2608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
387984b
test(azure-upgrade): point java migration e2e tests at upstream sampl…
XiaofeiCao Jun 9, 2026
2d9b6cc
Merge remote-tracking branch 'origin/main' into azure-upgrade/use-wel…
XiaofeiCao Jun 24, 2026
26ff0b6
apply change after switching to vally
XiaofeiCao Jun 24, 2026
f65f616
Merge branch 'microsoft:main' into azure-upgrade/use-well-known-org-f…
XiaofeiCao Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions evals/azure-upgrade/eval.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ stimuli:
- name: "Java SDK migration - client init to DefaultAzureCredential"
prompt: >-
Migrate my Java project from legacy Azure SDK to modern Azure SDK.
The project can be found under java-update-examples/azure-legacy-sdk-update-azure-client-initialization.
The project can be found under aad-java-manage-service-principals.
tags:
type: integration
tier: full
Expand All @@ -250,9 +250,9 @@ stimuli:
- "Continue with recommended options until complete."
environment:
commands:

@jongio jongio Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--sparse enables sparse-checkout mode but no git sparse-checkout set follows. The default cone pattern only materializes root-level files. Java sources live under src/, so they won't be checked out. This is likely why the eval CI check is failing.

Drop --sparse since this repo doesn't need sparse checkout:

Suggested change
commands:
- git clone --depth 1 https://github.com/Azure-Samples/aad-java-manage-service-principals.git

- git clone --depth 1 --sparse https://github.com/weidongxu-microsoft/java-update-examples.git
- cd java-update-examples && git sparse-checkout set azure-legacy-sdk-update-azure-client-initialization
- cd java-update-examples && git fetch --depth 1 origin 6d071296df8929482b0903241a23713a0bb952a4 && git checkout 6d071296df8929482b0903241a23713a0bb952a4
- git clone --depth 1 --sparse https://github.com/Azure-Samples/aad-java-manage-service-principals.git

@jongio jongio Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--sparse enables sparse-checkout mode but no git sparse-checkout set follows. The default cone pattern only materializes root-level files. I checked the repo tree at this commit and Java sources live under src/, so they won't be checked out.

Drop --sparse since this repo doesn't need sparse checkout:

Suggested change
- git clone --depth 1 --sparse https://github.com/Azure-Samples/aad-java-manage-service-principals.git
- git clone --depth 1 https://github.com/Azure-Samples/aad-java-manage-service-principals.git

Same fix needed on line 364 for batch-java-manage-batch-accounts.

- cd aad-java-manage-service-principals

@jongio jongio Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bare cd is a no-op. The next command already starts with cd aad-java-manage-service-principals && ..., so this line does nothing. It was meaningful before when git sparse-checkout set was chained here.

Remove it (same for line 365):

Suggested change
- cd aad-java-manage-service-principals
- cd aad-java-manage-service-principals && git fetch --depth 1 origin 83b446085a7ef35cf26b6d36255aa833aeb287bb && git checkout 83b446085a7ef35cf26b6d36255aa833aeb287bb

- cd aad-java-manage-service-principals && git fetch --depth 1 origin 83b446085a7ef35cf26b6d36255aa833aeb287bb && git checkout 83b446085a7ef35cf26b6d36255aa833aeb287bb
config:
timeout: "45m"
graders:
Expand Down Expand Up @@ -296,7 +296,7 @@ stimuli:
- name: "Java SDK migration - EventProcessorHost to BlobCheckpointStore"
prompt: >-
Migrate my Java project from legacy Azure SDK to modern Azure SDK.
The project can be found under java-update-examples/azure-legacy-sdk-update-eventhubs-v3.
The project can be found under logstash-input-azure_event_hubs/.ci/integration/event_hub_consumer
tags:
type: integration
tier: full
Expand All @@ -306,9 +306,9 @@ stimuli:
- "Continue with recommended options until complete."
environment:
commands:
- git clone --depth 1 --sparse https://github.com/weidongxu-microsoft/java-update-examples.git
- cd java-update-examples && git sparse-checkout set azure-legacy-sdk-update-eventhubs-v3
- cd java-update-examples && git fetch --depth 1 origin 6d071296df8929482b0903241a23713a0bb952a4 && git checkout 6d071296df8929482b0903241a23713a0bb952a4
- git clone --depth 1 --sparse https://github.com/logstash-plugins/logstash-input-azure_event_hubs.git
- cd logstash-input-azure_event_hubs && git sparse-checkout set .ci/integration/event_hub_consumer
- cd logstash-input-azure_event_hubs && git fetch --depth 1 origin 4a05eea79342f1d451162d1a3e26270f6a484b4f && git checkout 4a05eea79342f1d451162d1a3e26270f6a484b4f
config:
timeout: "45m"
graders:
Expand Down Expand Up @@ -351,7 +351,7 @@ stimuli:
- name: "Java SDK migration - Batch applicationPackages define"
prompt: >-
Migrate my Java project from legacy Azure SDK to modern Azure SDK.
The project can be found under java-update-examples/azure-legacy-sdk-update-batch-java-manage-batch-accounts.
The project can be found under batch-java-manage-batch-accounts.
tags:
type: integration
tier: full
Expand All @@ -361,9 +361,9 @@ stimuli:
- "Continue with recommended options until complete."
environment:
commands:

@jongio jongio Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here: --sparse without a subsequent git sparse-checkout set means src/ won't be checked out.

Suggested change
commands:
- git clone --depth 1 https://github.com/Azure-Samples/batch-java-manage-batch-accounts.git

- git clone --depth 1 --sparse https://github.com/weidongxu-microsoft/java-update-examples.git
- cd java-update-examples && git sparse-checkout set azure-legacy-sdk-update-batch-java-manage-batch-accounts
- cd java-update-examples && git fetch --depth 1 origin 6d071296df8929482b0903241a23713a0bb952a4 && git checkout 6d071296df8929482b0903241a23713a0bb952a4
- git clone --depth 1 --sparse https://github.com/Azure-Samples/batch-java-manage-batch-accounts.git
- cd batch-java-manage-batch-accounts
- cd batch-java-manage-batch-accounts && git fetch --depth 1 origin 105a0766ca9d1c7866763f950dfe6700d25fa216 && git checkout 105a0766ca9d1c7866763f950dfe6700d25fa216
config:
timeout: "45m"
graders:
Expand Down
Loading
Loading