fix: fix mvc sample#2667
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Azure deploy integration test that clones the ASP.NET Core Docs “MvcMovie” sample to use the new .NET 9 completed sample folder, keeping the brownfield deployment scenario aligned with the upstream repo layout.
Changes:
- Update the sparse-checkout path for the MvcMovie 9.0 sample to
.../sample/9.0-completed.
Show a summary per file
| File | Description |
|---|---|
tests/azure-deploy/integration.test.ts |
Adjusts the sparse-checkout path used when cloning the ASP.NET Core Docs MvcMovie sample for the brownfield deployment integration test. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced Jun 18, 2026
RickWinter
reviewed
Jun 18, 2026
msalaman
approved these changes
Jun 22, 2026
msalaman
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MvcMovie90 test has been consistently failing for a long time. Test runs all run into the same 500 error when trying to access the Home controller of the app, even though the app service's /health controller returns 200. The app insights traces indicate there is a runtime exception about "Index" view not found. In a few test runs, the agent was able to modify the code to get the Home view return 200, aligning with the finding of the app insights trace.
I looked into the code and I suspect the app we let the agent to deploy has the bug that caused this. The parent readme has a vague sentence saying that "The completed sample is in the <.NET version>-completed folder. The MvcMovie<.NET version> sample is used for documentation and is difficult to use". I decided to point the test to use the app in the 9.0-completed folder instead.
https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/tutorials/first-mvc-app/start-mvc/sample
Checklist
cd tests && npm test)fix:,feat:,feature:,chore:,misc:,test:,eval:tests/,npm run test:integration -- <skill>ornpm run test:vally -- --skill <skill>)Related Issues