Skip to content

fix: fix mvc sample#2667

Merged
JasonYeMSFT merged 1 commit into
microsoft:mainfrom
JasonYeMSFT:chuye/mvc-sample
Jun 22, 2026
Merged

fix: fix mvc sample#2667
JasonYeMSFT merged 1 commit into
microsoft:mainfrom
JasonYeMSFT:chuye/mvc-sample

Conversation

@JasonYeMSFT

@JasonYeMSFT JasonYeMSFT commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

This MvcMovie90 test has been consistently failing for a long time. Test runs all run into the same 500 error when trying to access the Home controller of the app, even though the app service's /health controller returns 200. The app insights traces indicate there is a runtime exception about "Index" view not found. In a few test runs, the agent was able to modify the code to get the Home view return 200, aligning with the finding of the app insights trace.

I looked into the code and I suspect the app we let the agent to deploy has the bug that caused this. The parent readme has a vague sentence saying that "The completed sample is in the <.NET version>-completed folder. The MvcMovie<.NET version> sample is used for documentation and is difficult to use". I decided to point the test to use the app in the 9.0-completed folder instead.

https://github.com/dotnet/AspNetCore.Docs/tree/main/aspnetcore/tutorials/first-mvc-app/start-mvc/sample

Checklist

  • Tests pass locally (cd tests && npm test)
  • Title has one of the prefixes: fix:, feat:, feature:, chore:, misc:, test:, eval:
  • If modifying skill descriptions: verified routing correctness with integration tests (In tests/, npm run test:integration -- <skill> or npm run test:vally -- --skill <skill>)

Related Issues

Copilot AI review requested due to automatic review settings June 18, 2026 18:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure deploy integration test that clones the ASP.NET Core Docs “MvcMovie” sample to use the new .NET 9 completed sample folder, keeping the brownfield deployment scenario aligned with the upstream repo layout.

Changes:

  • Update the sparse-checkout path for the MvcMovie 9.0 sample to .../sample/9.0-completed.
Show a summary per file
File Description
tests/azure-deploy/integration.test.ts Adjusts the sparse-checkout path used when cloning the ASP.NET Core Docs MvcMovie sample for the brownfield deployment integration test.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Comment thread tests/azure-deploy/integration.test.ts
@JasonYeMSFT JasonYeMSFT merged commit d4563f6 into microsoft:main Jun 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants