eval: azure-quotas grader bash tool pattern#2681
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the azure-quotas Vally eval grader’s tool-name regex to avoid unintentionally matching non-execution tools (e.g., read_bash) and causing grader failures due to missing command arguments.
Changes:
- Updated the
tool-callsgraderrequired[].namepattern in three stimuli to change shell tool matching behavior.
Show a summary per file
| File | Description |
|---|---|
evals/azure-quotas/eval.yaml |
Tweaks the shell tool-name regex used by tool-calls graders for `check-quota.(sh |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 3
msalaman
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the azure-quotas eval grader bash tool pattern to correct matching behavior. read_bash tool also matches the pattern and since they don't have "command" argument, vally produces grader failures.
Checklist
cd tests && npm test)fix:,feat:,feature:,chore:,misc:,test:,eval:tests/,npm run test:integration -- <skill>ornpm run test:vally -- --skill <skill>)Related Issues