Skip to content

fix: harden GitHub Actions workflows #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dagecko wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: harden GitHub Actions workflows #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/generator-generic-ossf-slsa3-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
actions: read # To read the workflow path.
id-token: write # To sign the provenance.
contents: write # To add assets to a release.
uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v1.4.0
uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@68bad40844440577b33778c9f29077a3388838e9 # v1.4.0
with:
Comment on lines 61 to 64
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says it "pins all GitHub Actions to immutable commit SHAs", but there are still workflows using mutable version tags (e.g., .github/workflows/stale.yml uses actions/stale@v10, and this workflow still uses actions/checkout@v6). Either pin the remaining uses: entries to SHAs as well, or update the PR description/scope so it accurately reflects what’s changed.

Copilot uses AI. Check for mistakes.
base64-subjects: "${{ needs.build.outputs.digests }}"
upload-assets: true # Optional: Upload to a new release
2 changes: 1 addition & 1 deletion .github/workflows/lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ jobs:
lock:
runs-on: ubuntu-latest
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow doesn’t set an explicit permissions: block for the GITHUB_TOKEN, so it will inherit the repository default (often broader than needed). Other workflows in this repo define least-privilege permissions; consider adding permissions: issues: write (and nothing else) to the lock job to reduce token scope.

Suggested change
runs-on: ubuntu-latest
runs-on: ubuntu-latest
permissions:
issues: write

Copilot uses AI. Check for mistakes.
steps:
- uses: OSDKDev/lock-issues@v1.1
- uses: OSDKDev/lock-issues@2372e7b39b61a49bb1980dbd3544837d7d40f01d # v1.1
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"