convert to warn instead of warnings so conftest and __init__ messages are captured even though they are prior to individual tests

Author: bpkroth

mlos_bench/mlos_bench/tests/__init__.py

@@ -15,7 +15,7 @@
 import stat
 import sys
 from datetime import tzinfo
-from logging import warning
+from warnings import warn
 from subprocess import run
 
 import pytest
@@ -62,16 +62,16 @@
         uid = st.st_uid
         gid = st.st_gid
     except Exception as e:  # pylint: disable=broad-except
-        warning(f"Could not stat {DOCKER_SOCK_PATH}: {e}")
+        warn(f"Could not stat {DOCKER_SOCK_PATH}: {e}", UserWarning)
     try:
         if sys.platform != "win32":
             current_uid = os.getuid()
             current_gid = os.getgid()
             gids = os.getgroups()
         if not os.access(DOCKER_SOCK_PATH, os.W_OK):
-            warning(f"Docker socket {DOCKER_SOCK_PATH} is not writable.")
+            warn(f"Docker socket {DOCKER_SOCK_PATH} is not writable.", UserWarning)
     except Exception as e:  # pylint: disable=broad-except
-        warning(f"Could not get current user info: {e}")
+        warn(f"Could not get current user info: {e}", UserWarning)
 
     cmd = run(
         "docker builder inspect default || docker buildx inspect default",
@@ -85,16 +85,17 @@
         line for line in stdout.splitlines() if "Platform" in line and "linux" in line
     ):
         DOCKER = None
-        warning(
+        warn(
             "Docker is available but missing buildx support for targeting linux platform:\n"
             + f"stdout:\n{stdout}\n"
             + f"stderr:\n{stderr}\n"
             + f"sock_path: {DOCKER_SOCK_PATH} sock mode: {mode} sock uid: {uid} gid: {gid}\n"
-            + f"current_uid: {current_uid} groups: {gids}\n"
+            + f"current_uid: {current_uid} groups: {gids}\n",
+            UserWarning,
         )
 
 if not DOCKER:
-    warning("Docker is not available on this system. Some tests will be skipped.")
+    warn("Docker is not available on this system. Some tests will be skipped.", UserWarning)
 
 # A decorator for tests that require docker.
 # Use with @requires_docker above a test_...() function.
@@ -107,7 +108,7 @@
 # Use with @requires_ssh above a test_...() function.
 SSH = shutil.which("ssh")
 if not SSH:
-    warning("ssh is not available on this system.  Some tests will be skipped.")
+    warn("ssh is not available on this system.  Some tests will be skipped.", UserWarning)
 requires_ssh = pytest.mark.skipif(not SSH, reason="ssh is not available on this system.")
 
 # A common seed to use to avoid tracking down race conditions and intermingling
@@ -232,14 +233,16 @@ def are_dir_trees_equal(dir1: str, dir2: str) -> bool:
         or len(dirs_cmp.right_only) > 0
         or len(dirs_cmp.funny_files) > 0
     ):
-        warning(
-            f"Found differences in dir trees {dir1}, {dir2}:\n"
-            f"{dirs_cmp.diff_files}\n{dirs_cmp.funny_files}"
+        warn(
+            UserWarning(
+                f"Found differences in dir trees {dir1}, {dir2}:\n"
+                f"{dirs_cmp.diff_files}\n{dirs_cmp.funny_files}"
+            )
         )
         return False
     (_, mismatch, errors) = filecmp.cmpfiles(dir1, dir2, dirs_cmp.common_files, shallow=False)
     if len(mismatch) > 0 or len(errors) > 0:
-        warning(f"Found differences in files:\n{mismatch}\n{errors}")
+        warn(f"Found differences in files:\n{mismatch}\n{errors}", UserWarning)
         return False
     for common_dir in dirs_cmp.common_dirs:
         new_dir1 = os.path.join(dir1, common_dir)

mlos_viz/mlos_viz/tests/conftest.py

@@ -7,7 +7,7 @@
 import os
 import sys
 from glob import glob
-from logging import warning
+from warnings import warn
 from pathlib import Path
 
 from mlos_bench.tests import tunable_groups_fixtures
@@ -22,8 +22,6 @@
 tunable_groups_config = tunable_groups_fixtures.tunable_groups_config
 tunable_groups = tunable_groups_fixtures.tunable_groups
 
-warning("test")
-
 # Workaround for #1004
 # See Also: https://github.com/python/cpython/issues/111754
 if sys.platform == "win32":
@@ -53,6 +51,8 @@
                         )
                     ).parent
                 )
-                warning(f"""Setting {env_var} to {os.environ[env_var]}""")
+                warn(f"""Setting {env_var} to {os.environ[env_var]}""", UserWarning)
             except StopIteration:
-                warning(f"{env_var} not found, some Tcl/Tk functionality may be limited.")
+                warn(
+                    UserWarning(f"{env_var} not found, some Tcl/Tk functionality may be limited.")
+                )