Skip to content

Commit a883a7e

Browse files
authored
mypy linting fixup (#987)
# Pull Request ## Title mypy linting fixup ______________________________________________________________________ ## Description mypy linting fixup ______________________________________________________________________ ## Type of Change - 🛠️ Bug fix ______________________________________________________________________ ## Testing Unit tests and lints checks. ______________________________________________________________________ ## Additional Notes (optional) Can be merged before any of the other refactor series. ______________________________________________________________________
1 parent ed89170 commit a883a7e

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

mlos_core/mlos_core/data_classes.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,19 @@ def __len__(self) -> int:
283283

284284
def __iter__(self) -> Iterator["Observation"]:
285285
for idx in self._configs.index:
286+
config = self._configs.loc[idx]
287+
assert isinstance(config, pd.Series)
288+
score = self._scores.loc[idx]
289+
assert isinstance(score, pd.Series)
290+
context = self._contexts.loc[idx] if self._contexts is not None else None
291+
assert isinstance(context, (pd.Series, type(None)))
292+
metadata = self._metadata.loc[idx] if self._metadata is not None else None
293+
assert isinstance(metadata, (pd.Series, type(None)))
286294
yield Observation(
287-
config=self._configs.loc[idx],
288-
score=self._scores.loc[idx],
289-
context=None if self._contexts is None else self._contexts.loc[idx],
290-
metadata=None if self._metadata is None else self._metadata.loc[idx],
295+
config=config,
296+
score=score,
297+
context=context,
298+
metadata=metadata,
291299
)
292300

293301
def __repr__(self) -> str:

0 commit comments

Comments
 (0)