Split docker tests fixtures#1003
Merged
bpkroth merged 61 commits intomicrosoft:mainfrom Oct 24, 2025
Merged
Conversation
motus
approved these changes
Oct 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors docker test fixtures to enable independent setup and teardown of different docker-compose projects. This improves test performance by allowing tests to only initialize their required services (e.g., SQL tests don't need SSH fixtures) and enhances parallelism by making docker-compose projects independent.
Key Changes
- Moved shared docker fixture logic from
conftest.pyto a newdocker_fixtures_util.pymodule - Added fixture-specific
docker_compose_fileanddocker_compose_project_namefixtures in SQL and SSH test suites - Updated multiple
conftest.pyfiles to import and expose the relocated docker fixtures
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
mlos_bench/mlos_bench/tests/docker_fixtures_util.py |
New module containing shared docker fixture implementations previously in main conftest |
mlos_bench/mlos_bench/tests/conftest.py |
Removed docker fixture definitions (moved to docker_fixtures_util.py) |
mlos_bench/mlos_bench/tests/storage/sql/fixtures.py |
Added SQL-specific docker_compose_file and docker_compose_project_name fixtures |
mlos_bench/mlos_bench/tests/storage/conftest.py |
Imports and exposes SQL docker fixtures |
mlos_bench/mlos_bench/tests/services/remote/ssh/fixtures.py |
Added SSH-specific docker_compose_file and docker_compose_project_name fixtures |
mlos_bench/mlos_bench/tests/services/remote/ssh/conftest.py |
Imports and exposes SSH docker fixtures |
mlos_bench/mlos_bench/tests/environments/remote/conftest.py |
Imports and exposes SSH docker fixtures for remote environment tests |
mlos_bench/mlos_bench/tests/__init__.py |
Added imports for grp and pwd modules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
motus
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Split docker test fixtures
Description
Splits docker test fixtures so that individual docker-compose projects can be setup and torn down independently.
This improves single test performance (e.g., when SQL tests don't need to setup SSH test fixtures) and parallelism by allowing each to operate independently.
Type of Change
Additional Notes (optional)
Should be merged after #994