Fail a trial if it produces empty csv file#1006
Merged
motus merged 4 commits intomicrosoft:mainfrom Oct 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling for CSV result files by detecting and failing trials that produce empty CSV files, following up on issue #998. The changes prevent crashes when encountering malformed or empty result files.
Key Changes:
- Added exception handling for empty CSV files that would otherwise cause pandas to raise an
EmptyDataError - Fixed a potential
IndexErrorin command line parsing when encountering empty tokens - Added comprehensive test coverage for the new empty file scenario
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mlos_bench/mlos_bench/environments/local/local_env.py | Added try-except block to catch EmptyDataError when reading CSV files and fail the trial gracefully |
| mlos_bench/mlos_bench/services/local/local_exec.py | Fixed indexing bug that could cause IndexError with empty tokens by using slice notation |
| mlos_bench/mlos_bench/tests/environments/local/local_env_test.py | Added new test case for zero-length CSV files and clarified existing test for CSV files with headers but no data |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
for more information, see https://pre-commit.ci
bpkroth
approved these changes
Oct 23, 2025
Contributor
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Fail a trial if it produces empty csv file.
A follow-up to #998
Description
split_cmdline()function to allow empty token strings (occurs in the new unit test)Type of Change
Testing
Run unit tests as usual