Handle the case when the benchmark script produces an empty CSV#996
Merged
motus merged 5 commits intomicrosoft:mainfrom Oct 22, 2025
Merged
Handle the case when the benchmark script produces an empty CSV#996motus merged 5 commits intomicrosoft:mainfrom
motus merged 5 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR handles edge cases where benchmark scripts produce empty CSV files despite returning successful exit codes. The changes ensure robust handling of empty metrics files and improve test infrastructure to verify different failure scenarios.
- Added validation to check for empty CSV files and mark trials as failed
- Enhanced test framework to support flexible status checking for different test scenarios
- Fixed column specification in DataFrame creation for optimizer
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| local_env.py | Added check for empty CSV files and return FAILED status |
| init.py | Enhanced test helper function to support flexible status expectations |
| local_env_test.py | Added new test case for empty CSV file scenario |
| local_env_vars_test.py | Updated test call to use keyword arguments |
| mlos_core_optimizer.py | Fixed DataFrame creation with explicit column specification |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a9c7ac1 to
b30ba63
Compare
bpkroth
reviewed
Oct 22, 2025
bpkroth
approved these changes
Oct 22, 2025
Contributor
bpkroth
left a comment
There was a problem hiding this comment.
Minor improvement suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Handle the case when a script invoked by
local_envfails silently (i.e., with error code 0) and produces an empty metrics CSV file.Description
Type of Change
Testing
added a new unit test to cover the case
Closes #998