Tuples (#214)

* Remove dependency on tuple from SpacePinVisualizer.

* Bump patch version to 1.5.3.

* Update packaging files for v1.5.3, and lower Unity dependency for core and examples to U2018.4.

* Minor documentation updates (esp ASA only targets ARM64 on HL2).

* Delete unused documentaton icons.

Author: fast-slow-still

Assets/WorldLocking.Core/Scripts/WorldLockingManager.cs

@@ -35,7 +35,7 @@ public class WorldLockingManager
         /// allowing quick visual verification of the version of World Locking Tools for Unity currently installed.
         /// It has no effect in code, but serves only as a label.
         /// </summary>
-        public static string Version => "1.5.2";
+        public static string Version => "1.5.3";
 
         /// <summary>
         /// The configuration settings may only be set as a block.

Assets/WorldLocking.Tools/Scripts/SpacePinMeshVisualizer.cs

@@ -149,6 +149,20 @@ private static Pose GetGlobalFromLocked()
             return globalFromLocked;
         }
 
+        private struct IndexedTriangle
+        {
+            public int index0;
+            public int index1;
+            public int index2;
+
+            public IndexedTriangle(int i0, int i1, int i2)
+            {
+                index0 = i0;
+                index1 = i1;
+                index2 = i2;
+            }
+        }
+
         /// <summary>
         /// Generates the whole mesh inside the triangulation data, except for the boundary triangles/vertices.
         /// </summary>
@@ -171,7 +185,7 @@ private Mesh GenerateTriangulationWireFrameMesh()
 
             wholeMesh.vertices = vertices;
 
-            List<(int, int, int)> trimmedTriangles = new List<(int, int, int)>();
+            List<IndexedTriangle> trimmedTriangles = new List<IndexedTriangle>();
 
             for (int i = 0; i < triangulator.Triangles.Length; i += 3)
             {
@@ -187,17 +201,21 @@ private Mesh GenerateTriangulationWireFrameMesh()
                 if (currentInterpolant != null && (triangleDataSameAsClosestTriangle && !AnyWeightInTriangleZero()))
                     continue;
 
-                trimmedTriangles.Add((triangulator.Triangles[i] - 4, triangulator.Triangles[i + 1] - 4, triangulator.Triangles[i + 2] - 4));
+                trimmedTriangles.Add(new IndexedTriangle(
+                        triangulator.Triangles[i] - 4,
+                        triangulator.Triangles[i + 1] - 4,
+                        triangulator.Triangles[i + 2] - 4
+                    ));
             }
 
             int[] tris = new int[trimmedTriangles.Count * 3];
 
             int triIndex = 0;
             for (int i = 0; i < trimmedTriangles.Count; i++)
             {
-                tris[triIndex] = trimmedTriangles[i].Item1;
-                tris[triIndex + 1] = trimmedTriangles[i].Item2;
-                tris[triIndex + 2] = trimmedTriangles[i].Item3;
+                tris[triIndex] = trimmedTriangles[i].index0;
+                tris[triIndex + 1] = trimmedTriangles[i].index1;
+                tris[triIndex + 2] = trimmedTriangles[i].index2;
                 triIndex += 3;
             }
 

DocGen/Documentation/Concepts.md

@@ -4,27 +4,27 @@
 
 In the day to day physical world, space is well described by a stationary coordinate system. A motionless object in a stationary coordinate system will continue having the same coordinates forever. A group of objects laid out in a specific configuration will maintain that configuration. Two objects moving with identical velocities will remain at a fixed offset from each other.
 
-These and similar laws are such an basic part of existence that when they no longer hold, intuition about the world becomes unreliable. 
+These and similar laws are such an basic part of existence that when they no longer hold, intuition about the world becomes unreliable.
 
 ## Previous solutions
 
-Unity's *global coordinate space* and *spatial anchors* each address different aspects of the problems caused by sensor inaccuracies and drift. 
+Unity's *global coordinate space* and *spatial anchors* each address different aspects of the problems caused by sensor inaccuracies and drift.
 
 Unity's global coordinate space provides a stable frame of reference, in which holographic objects remain fixed relative to one another.  While objects in this space will behave consistently relative to each other, consistency with the physical world is not guaranteed nor generally provided. Especially when the user is moving around, inconsistencies will develop.
 
-Unity's spatial anchors can maintain a hologram's position in the physical world when the user is mobile, but at the sacrifice of self consistency within the virtual world. Different anchors are constantly moving relative to one another. They are also moving through the global coordinate space, making simple tasks like layout difficult, and physics simulation problematic. 
+Unity's spatial anchors can maintain a hologram's position in the physical world when the user is mobile, but at the sacrifice of self consistency within the virtual world. Different anchors are constantly moving relative to one another. They are also moving through the global coordinate space, making simple tasks like layout difficult, and physics simulation problematic.
 
 ## The source of the problem
 
-Discussion here will center around HoloLens technology, but these concepts apply generally to inside out markerless tracking techniques, especially as augmented by inertial systems.
+Discussion here will center around HoloLens technology, but these concepts apply generally to inside out marker-less tracking techniques, especially as augmented by inertial systems.
 
 The HoloLens is amazing at determining where it is relative to visible features in the surroundings. By extension, it is also amazing at positioning other virtual objects by those same visible features. So when the user is sitting or standing in a roughly constant position, the device is great at keeping virtual objects registered with visible physical reference points. A virtual cup placed on a physical table, will mostly stay in the same spot on the surface of the table.  
 
 That's when the HoloLens is confined to the same small volume, with a constant set of visible features in view for reference. But there are other interesting scenarios.
 
 When the user gets up and moves about the room, or possibly even between rooms, the HoloLens must switch between old features leaving view and new features coming into view. Without getting into implementation details, it's clear to see that while in transit, tracking accuracy is going to be very much degraded.
 
-Here's a simplistic scenario for context. 
+Here's a simplistic scenario for context.
 
 ### Illustration
 
@@ -36,17 +36,17 @@ Now looking around at point B, good visible features are recorded. Tracking and
 
 When at point A, things around point A look great, and when around point B, things at point B look great. But there's an inconsistency. The 10 meters between points A and B in physical space are only 9 meters in virtual space. That's often referred to as "the scale problem", although "the distance problem" might be more accurate. Regardless, we'll get back to when that's a problem soon.
 
-But first, the user walks back to point A. This time the tracking errors make the 10 meters walk from B to A in physical space add up to 10.5 meters in virtual space. And that means that the full walk from A to B to A adds up to a net move of 1.5 meters, when it should obviously be 0.0 meters. This is an obvious problem. A hologram placed at point A before the walk will now appear 1.5 meters away from point A. 
+But first, the user walks back to point A. This time the tracking errors make the 10 meters walk from B to A in physical space add up to 10.5 meters in virtual space. And that means that the full walk from A to B to A adds up to a net move of 1.5 meters, when it should obviously be 0.0 meters. This is an obvious problem. A hologram placed at point A before the walk will now appear 1.5 meters away from point A.
 
 This is where spatial anchors can help. After walking to B and back, the system recognizes that it is back at point A, yet the head's Unity coordinates have changed by 1.5 meters. But if the hologram at point A has a spatial anchor attached, the spatial anchor can think "I'm at point A, the head is at point A, but my coordinates differ from the head's by 1.5 meters. I'll just change my coordinates by 1.5 meters so that we're in agreement again." And a spatial anchor at point C, a meter to the left of the user, is going through the same process. In essence, the spatial anchor constantly redefines where point A is in Unity space so that the head's coordinates are always right. And each spatial anchor does this independently for its place in the physical world.  
 
 ## World Locking Tools for Unity
 
-World Locking Tools keeps an internal supply of spatial anchors it spreads as the user moves around. It analyses the coordinates of the camera and those spatial anchors every frame. It detects when all of those spatial anchors are moving over 1.5 meters to match the coordinates of the head, and says "Hmm, instead of changing the coordinates of everything in the world to compensate for the head having different coordinates than the last time it was here, I'll just fix the head's coordinates instead." 
+World Locking Tools keeps an internal supply of spatial anchors it spreads as the user moves around. It analyses the coordinates of the camera and those spatial anchors every frame. It detects when all of those spatial anchors are moving over 1.5 meters to match the coordinates of the head, and says "Hmm, instead of changing the coordinates of everything in the world to compensate for the head having different coordinates than the last time it was here, I'll just fix the head's coordinates instead."
 
 That means that, rather than having to have a spatial anchor drag a hologram through Unity space so that it will remain fixed in physical space, the entire Unity world space is locked to physical space. If a hologram is motionless in Unity space, it will remain motionless relative to the physical world features around it. And just as importantly, it will remain fixed relative to the virtual features around it.
 
-Obviously it's more complicated under the hood than that. For example, remember that a problem with the spatial anchors is that they move independently, so don't always agree with each other. The underlying FrozenWorld engine arbitrates those disagreements to come up with the most perceptually correct camera correction, and does that every frame. 
+Obviously it's more complicated under the hood than that. For example, remember that a problem with the spatial anchors is that they move independently, so don't always agree with each other. The underlying FrozenWorld engine arbitrates those disagreements to come up with the most perceptually correct camera correction, and does that every frame.
 
 ## The scale problem again
 
@@ -58,7 +58,7 @@ This can be inconvenient in many forms, but it becomes a blocking issue when obj
 
 And so far in this discussion, the minimum information required to fix the problem has not been introduced.
 
-World Locking Tools addresses that problem with the [Space Pins](Concepts/Advanced/SpacePins.md) API, which allows the application to supply enough information relating the physical world and holographic world to correct for the errors in distance traveled. This allows large holograms to appear aligned with the physical world all over. 
+World Locking Tools addresses that problem with the [Space Pins](Concepts/Advanced/SpacePins.md) API, which allows the application to supply enough information relating the physical world and holographic world to correct for the errors in distance traveled. This allows large holograms to appear aligned with the physical world all over.
 
 ## Next
 
@@ -68,4 +68,4 @@ These advanced mechanisms will be covered in later sections, but it is useful to
 
 * [FAQ](IntroFAQ.md)
 * [The basic system](Concepts/BasicConcepts.md)
-* [Advanced topics](Concepts/AdvancedConcepts.md)
+* [Advanced topics](Concepts/AdvancedConcepts.md)

DocGen/Documentation/HowTos/WLT_ASA.md

@@ -14,12 +14,13 @@ WLT supports:
 * Unity 2018.4, Unity 2019.4, Unity 2020.3
 * HoloLens, HoloLens2, Android, and iOS
 * Unity Legacy XR, XR SDK, or OpenXR
-* Azure Spatial Anchors v2.9.0-v2.10.0
+* Azure Spatial Anchors v2.9.0-v2.10.2
 
-Use of ASA imposes these additional restrictions:
+Use of ASA v2.9+ imposes these additional restrictions:
 
 * Unity 2020.3 or later
 * XR SDK or OpenXR
+* At the time of this writing, ASA only targets ARM64 (not ARM32) on HoloLens2. Check the latest [ASA documentation](https://docs.microsoft.com/azure/spatial-anchors/quickstarts/get-started-unity-hololens?tabs=azure-portal).
 
 ## Setup for using ASA with WLT
 

DocGen/External/ReadMeImages/MRTK170802_Short_17.png

@@ -2,6 +2,8 @@
 
 [See release notes](https://github.com/microsoft/MixedReality-WorldLockingTools-Unity/releases)
 
+## 1.5.3 - Remove dependency on tuple, and add MR Feature Tool support back to Unity 2018.4.
+
 ## 1.5.2 - Delay startup for Holographic Remoting.
 
 ## 1.5.1 - Fixes for local world locking.

DocGen/External/ReadMeImages/MRTK170802_Short_18.png

@@ -1,7 +1,7 @@
 {
   "name": "com.microsoft.mixedreality.wlt.asa",
   "displayName": "WLT-ASA",
-  "version": "1.5.2",
+  "version": "1.5.3",
   "unity": "2020.3",
   "msftFeatureCategory": "World Locking Tools",
   "description": "World Locking Tools for Unity (WLT) + Azure Spatial Anchors (ASA)\n\nThis optional add-on to WLT leverages ASA to persist coordinate spaces across sessions and share them across devices.\nCross platform support includes HoloLens, Android, and iOS.",
@@ -35,7 +35,7 @@
   },
   "dependencies": {
     "com.microsoft.azure.spatial-anchors-sdk.core": "2.9.0",
-    "com.microsoft.mixedreality.worldlockingtools": "1.5.2"
+    "com.microsoft.mixedreality.worldlockingtools": "1.5.3"
   },
   "files": [
     "WorldLocking.ASA",