feat: Standardize Bicep Parameters for Code Modernization#115
Closed
VishalS-Microsoft wants to merge 5 commits into
Closed
feat: Standardize Bicep Parameters for Code Modernization#115VishalS-Microsoft wants to merge 5 commits into
VishalS-Microsoft wants to merge 5 commits into
Conversation
VishalS-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
June 3, 2025 13:42
Roopan-Microsoft
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several updates to enhance parameter customization and configuration for Azure deployments. The changes focus on improving documentation, refining infrastructure templates, and aligning default parameter values across files.
Documentation Updates:
docs/CustomizingAzdParameters.md: Replaced individual parameter setting examples with a comprehensive table listing all customizable parameters, their types, default values, and purposes. Added instructions on how to set parameters using theazd env setcommand.Infrastructure Template Enhancements:
infra/main.bicep: Added new parametersdeploymentType(default:'GlobalStandard') andllmModel(default:'gpt-4o') to define the model deployment type and LLM model name directly in the infrastructure template.infra/main.bicep: Removed hardcoded values fordeploymentTypeandllmModelfrom variable definitions, ensuring these values are now parameter-driven for better flexibility.Parameter Alignment:
infra/main.bicepparam: Updated parameter definitions to align with environment variables, includingcapacity,deploymentType, andllmModel, ensuring consistency with the documentation and infrastructure templates.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information