feat: Merging the NSG bicep changes from dev to main

[Abdul-Microsoft]

Purpose

• This pull request introduces significant updates to the Azure Bicep infrastructure modules to enhance the configuration of Azure Bastion Host and its associated subnet. The changes include adding support for detailed subnet configurations, integrating network security groups (NSGs) with custom rules, and refactoring parameter structures for better modularity and extensibility.

Enhancements to Azure Bastion Host Configuration:

• Support for Subnet Configuration: Replaced the subnetAddressPrefixes parameter with a more comprehensive subnet parameter, which includes properties such as name, addressPrefixes, and an optional networkSecurityGroup configuration. (infra/modules/network.bicep [1] infra/modules/network/bastionHost.bicep [2] [3] [4] infra/samples/network-subnet-design.bicep [5]

• Integration of Network Security Groups: Added support for defining NSGs with custom security rules for Azure Bastion Host subnets. This includes rules for inbound and outbound traffic such as allowing HTTPS, SSH, RDP, and Azure Cloud traffic. (infra/modules/network.bicep [1] infra/modules/network/bastionHost.bicep [2]

Refactoring and Dependency Management:

• Refactored Resource Dependencies: Updated the Bastion Host module to explicitly depend on the creation of its associated subnet, ensuring proper deployment order. (infra/modules/network/bastionHost.bicep infra/modules/network/bastionHost.bicepR86-R88)

• Improved Modularity: Introduced the subnetType import to encapsulate subnet configurations, promoting reusable and cleaner code. (infra/modules/network/bastionHost.bicep infra/modules/network/bastionHost.bicepL29-R57)

These updates improve the flexibility and security of the Azure Bastion Host deployment while aligning the codebase with best practices for modular infrastructure as code.

Does this introduce a breaking change?

• Yes
• No

Golden Path Validation

• I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

• I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

• ...

Other Information

[github-actions]

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀