Skip to content

fix: Update GPT model version and refactor Docker workflows#475

Merged
Avijit-Microsoft merged 23 commits into
microsoft:mainfrom
VishalSh-Microsoft:psl-conflictresolve-vs
Jul 17, 2026
Merged

fix: Update GPT model version and refactor Docker workflows#475
Avijit-Microsoft merged 23 commits into
microsoft:mainfrom
VishalSh-Microsoft:psl-conflictresolve-vs

Conversation

@VishalSh-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces several important changes across deployment workflows, infrastructure-as-code, backend telemetry, and documentation. The main themes are improved security and reliability in role assignments, enhanced compatibility with newer FastAPI versions, and modernization of CI/CD workflows to use GitHub Actions variables. There are also user experience improvements in deployment instructions.

CI/CD Workflow and Docker Image Build Improvements:

  • Updated all workflow files (job-docker-build.yml, job-deploy-linux.yml, job-deploy-windows.yml, and deploy-orchestrator.yml) to use GitHub Actions vars instead of secrets for the ACR_TEST_LOGIN_SERVER, improving maintainability and security. Also, refactored the Docker build job to support both workflow calls and manual dispatch, and improved the Azure Container Registry login logic. [1] [2] [3] [4] [5] [6] [7] [8]

Infrastructure Role Assignment and Permissions:

  • Changed role assignments in both infra/main.bicep and infra/main_custom.bicep to use explicit roleDefinition IDs for "Cognitive Services OpenAI User" and "Storage Blob Data Contributor" instead of role names, ensuring correct and future-proof permissions. The same updates are reflected in the generated infra/main.json. [1] [2] [3] [4] [5] [6]

Backend Telemetry Bugfix:

  • Added a patch to the backend’s telemetry instrumentor to handle a breaking change in FastAPI 0.119.0+, preventing 500 errors on CORS preflight requests by safely handling routes without a .path attribute. [1] [2]

Deployment Experience and Documentation:

  • Enhanced deployment instructions in DeploymentGuide.md to clarify user prompts, expected duration, and troubleshooting steps. Added a pre-provision hook in azure.yaml to display helpful messages to users if deployment fails. [1] [2]

Dependency Update:

  • Updated the axios dependency in the frontend to version 1.17.0 for improved security and bug fixes.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

Ragini-Microsoft and others added 21 commits June 11, 2026 11:55
…e-1106

fix: update GPT model version to 2024-11-20 across configuration files
chore: Updated Dependabot security packages
chore: update azure.yaml to show github issue URL
chore: down merging the changes from main
@VishalSh-Microsoft VishalSh-Microsoft changed the title Update GPT model version and refactor Docker workflows fix: Update GPT model version and refactor Docker workflows Jul 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes deployment and build workflows, updates infra role-assignment configuration to be more deterministic, and applies a backend telemetry patch to maintain compatibility with newer FastAPI behavior while also refreshing frontend dependencies and deployment docs.

Changes:

  • Refactors GitHub Actions Docker build/deploy workflows to use GitHub Actions vars for ACR login server and improves ACR login handling.
  • Updates infra role assignments to use explicit role definition GUIDs and propagates those changes into the generated ARM template.
  • Adds a FastAPI/OpenTelemetry instrumentation patch for route iteration changes, updates a backend smoke test accordingly, and improves deployment guidance plus an azd preprovision hook.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
src/tests/backend/app_test.py Updates route smoke test to use OpenAPI paths instead of iterating router routes.
src/frontend/package.json Bumps axios/react-router-dom; adds an override for brace-expansion.
src/frontend/package-lock.json Updates lockfile to reflect dependency/version changes.
src/backend/common/telemetry/patch_instrumentor.py Monkey-patches OTel FastAPI instrumentation to tolerate routes without .path.
infra/main.bicep Switches role assignments to explicit roleDefinition GUIDs.
infra/main_custom.bicep Mirrors the role assignment GUID updates from main.bicep.
infra/main.json Regenerated template reflecting role GUIDs (but currently contains invalid duplicated metadata/JSON issues).
docs/DeploymentGuide.md Adds deployment prompt/duration/troubleshooting guidance (currently duplicated).
azure.yaml Adds a Windows preprovision hook with guidance on filing issues with logs.
.github/workflows/job-docker-build.yml Refactors Docker build workflow to support workflow_dispatch and vars-based ACR usage.
.github/workflows/job-deploy-windows.yml Switches ACR login server reference from secrets to vars.
.github/workflows/job-deploy-linux.yml Switches ACR login server reference from secrets to vars.
.github/workflows/deploy-orchestrator.yml Adjusts orchestration to conditionally run docker-build without passing removed inputs.
Files not reviewed (1)
  • src/frontend/package-lock.json: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/main.json Outdated
Comment thread infra/main.json Outdated
Comment thread infra/main.json Outdated
Comment thread infra/main.json Outdated
Comment thread infra/main.json Outdated
Comment thread infra/main.json Outdated
Comment thread infra/main.json Outdated
Comment thread infra/main.json Outdated
Comment thread infra/main.json Outdated
Comment thread docs/DeploymentGuide.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • src/frontend/package-lock.json: Generated file

Comment thread docs/DeploymentGuide.md Outdated
Comment thread src/backend/common/telemetry/patch_instrumentor.py

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/frontend/package-lock.json: Generated file

Comment thread src/backend/common/telemetry/patch_instrumentor.py
@Avijit-Microsoft
Avijit-Microsoft merged commit 12e0f3c into microsoft:main Jul 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants