fix: Update GPT model version and refactor Docker workflows#475
Merged
Avijit-Microsoft merged 23 commits intoJul 17, 2026
Merged
Conversation
…to use GUID format
…e-1106 fix: update GPT model version to 2024-11-20 across configuration files
…orkflow ci: Refactor Docker workflow
chore: Updated Dependabot security packages
fix: merging main to dev
chore: update azure.yaml to show github issue URL
fix: fix upload bug
chore: down merging the changes from main
VishalSh-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
July 16, 2026 12:48
VishalSh-Microsoft
temporarily deployed
to
production
July 16, 2026 12:49 — with
GitHub Actions
Inactive
VishalSh-Microsoft
temporarily deployed
to
production
July 16, 2026 12:49 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes deployment and build workflows, updates infra role-assignment configuration to be more deterministic, and applies a backend telemetry patch to maintain compatibility with newer FastAPI behavior while also refreshing frontend dependencies and deployment docs.
Changes:
- Refactors GitHub Actions Docker build/deploy workflows to use GitHub Actions
varsfor ACR login server and improves ACR login handling. - Updates infra role assignments to use explicit role definition GUIDs and propagates those changes into the generated ARM template.
- Adds a FastAPI/OpenTelemetry instrumentation patch for route iteration changes, updates a backend smoke test accordingly, and improves deployment guidance plus an
azdpreprovision hook.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/backend/app_test.py | Updates route smoke test to use OpenAPI paths instead of iterating router routes. |
| src/frontend/package.json | Bumps axios/react-router-dom; adds an override for brace-expansion. |
| src/frontend/package-lock.json | Updates lockfile to reflect dependency/version changes. |
| src/backend/common/telemetry/patch_instrumentor.py | Monkey-patches OTel FastAPI instrumentation to tolerate routes without .path. |
| infra/main.bicep | Switches role assignments to explicit roleDefinition GUIDs. |
| infra/main_custom.bicep | Mirrors the role assignment GUID updates from main.bicep. |
| infra/main.json | Regenerated template reflecting role GUIDs (but currently contains invalid duplicated metadata/JSON issues). |
| docs/DeploymentGuide.md | Adds deployment prompt/duration/troubleshooting guidance (currently duplicated). |
| azure.yaml | Adds a Windows preprovision hook with guidance on filing issues with logs. |
| .github/workflows/job-docker-build.yml | Refactors Docker build workflow to support workflow_dispatch and vars-based ACR usage. |
| .github/workflows/job-deploy-windows.yml | Switches ACR login server reference from secrets to vars. |
| .github/workflows/job-deploy-linux.yml | Switches ACR login server reference from secrets to vars. |
| .github/workflows/deploy-orchestrator.yml | Adjusts orchestration to conditionally run docker-build without passing removed inputs. |
Files not reviewed (1)
- src/frontend/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VishalSh-Microsoft
temporarily deployed
to
production
July 16, 2026 12:59 — with
GitHub Actions
Inactive
VishalSh-Microsoft
temporarily deployed
to
production
July 16, 2026 12:59 — with
GitHub Actions
Inactive
VishalSh-Microsoft
temporarily deployed
to
production
July 16, 2026 13:06 — with
GitHub Actions
Inactive
VishalSh-Microsoft
temporarily deployed
to
production
July 16, 2026 13:06 — with
GitHub Actions
Inactive
Avijit-Microsoft
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several important changes across deployment workflows, infrastructure-as-code, backend telemetry, and documentation. The main themes are improved security and reliability in role assignments, enhanced compatibility with newer FastAPI versions, and modernization of CI/CD workflows to use GitHub Actions variables. There are also user experience improvements in deployment instructions.
CI/CD Workflow and Docker Image Build Improvements:
job-docker-build.yml,job-deploy-linux.yml,job-deploy-windows.yml, anddeploy-orchestrator.yml) to use GitHub Actionsvarsinstead ofsecretsfor theACR_TEST_LOGIN_SERVER, improving maintainability and security. Also, refactored the Docker build job to support both workflow calls and manual dispatch, and improved the Azure Container Registry login logic. [1] [2] [3] [4] [5] [6] [7] [8]Infrastructure Role Assignment and Permissions:
infra/main.bicepandinfra/main_custom.bicepto use explicit roleDefinition IDs for "Cognitive Services OpenAI User" and "Storage Blob Data Contributor" instead of role names, ensuring correct and future-proof permissions. The same updates are reflected in the generatedinfra/main.json. [1] [2] [3] [4] [5] [6]Backend Telemetry Bugfix:
.pathattribute. [1] [2]Deployment Experience and Documentation:
DeploymentGuide.mdto clarify user prompts, expected duration, and troubleshooting steps. Added a pre-provision hook inazure.yamlto display helpful messages to users if deployment fails. [1] [2]Dependency Update:
axiosdependency in the frontend to version 1.17.0 for improved security and bug fixes.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation