fix test cases

Author: Ayaz-Microsoft

src/tests/backend/common/database/test_cosmosdb.py

@@ -704,10 +704,11 @@ async def test_get_team_found(self, client):
         result = await client.get_team("test_team_id")
 
         assert result == mock_team
-        expected_query = "SELECT * FROM c WHERE c.team_id=@team_id AND c.data_type=@data_type"
+        expected_query = "SELECT * FROM c WHERE c.team_id=@team_id AND c.data_type=@data_type AND (c.user_id=@user_id OR c.is_default=true)"
         expected_params = [
             {"name": "@team_id", "value": "test_team_id"},
             {"name": "@data_type", "value": DataType.team_config},
+            {"name": "@user_id", "value": "test_user"},
         ]
         client.query_items.assert_called_once_with(expected_query, expected_params, TeamConfiguration)
 
@@ -739,9 +740,10 @@ async def test_get_all_teams(self, client):
         result = await client.get_all_teams()
 
         assert result == mock_teams
-        expected_query = "SELECT * FROM c WHERE c.data_type=@data_type ORDER BY c.created DESC"
+        expected_query = "SELECT * FROM c WHERE c.data_type=@data_type AND (c.user_id=@user_id OR c.is_default=true) ORDER BY c.created DESC"
         expected_params = [
             {"name": "@data_type", "value": DataType.team_config},
+            {"name": "@user_id", "value": "test_user"},
         ]
         client.query_items.assert_called_once_with(expected_query, expected_params, TeamConfiguration)
 
@@ -751,6 +753,7 @@ async def test_delete_team_success(self, client):
         mock_team = Mock(spec=TeamConfiguration)
         mock_team.id = "test_id"
         mock_team.session_id = "test_session"
+        mock_team.is_default = False
 
         # Mock get_team to return the team
         with patch.object(client, 'get_team', return_value=mock_team):
@@ -766,7 +769,7 @@ async def test_delete_team_not_found(self, client):
         with patch.object(client, 'get_team', return_value=None):
             result = await client.delete_team("test_team_id")
 
-        assert result is True
+        assert result is False
         client.delete_item.assert_not_called()
 
 

src/tests/backend/common/database/test_database_factory.py

@@ -113,6 +113,7 @@ async def test_get_database_creates_shared_instance_when_none_exists(self):
         mock_cosmos_client.database = Mock()
         mock_cosmos_client.container = Mock()
         mock_cosmos_client._initialized = True
+        mock_cosmos_client.user_id = "test_user"
 
         mock_config = Mock()
         mock_config.COSMOSDB_ENDPOINT = "https://test.documents.azure.com:443/"
@@ -476,6 +477,9 @@ async def test_config_values_passed_correctly(self):
         """Test that configuration values are passed correctly to CosmosDBClient."""
         mock_cosmos_client = Mock(spec=CosmosDBClient)
         mock_cosmos_client.initialize = AsyncMock()
+        mock_cosmos_client.client = Mock()
+        mock_cosmos_client.database = Mock()
+        mock_cosmos_client.container = Mock()
 
         mock_credentials = Mock()
         mock_config = Mock()
@@ -488,8 +492,11 @@ async def test_config_values_passed_correctly(self):
             with patch('backend.common.database.database_factory.config', mock_config):
                 await DatabaseFactory.get_database(user_id="custom_user")
 
-                # Verify all config values were passed correctly
-                mock_cosmos_class.assert_called_once_with(
+                # get_database builds a shared instance and a per-request
+                # instance, so the client is constructed twice with the same
+                # config-derived arguments.
+                assert mock_cosmos_class.call_count == 2
+                mock_cosmos_class.assert_called_with(
                     endpoint="https://custom.documents.azure.com:443/",
                     credential=mock_credentials,
                     database_name="custom_database",
@@ -498,8 +505,8 @@ async def test_config_values_passed_correctly(self):
                     user_id="custom_user"
                 )
 
-                # Verify get_azure_credentials was called
-                mock_config.get_azure_credentials.assert_called_once()
+                # Verify get_azure_credentials was invoked for each construction
+                assert mock_config.get_azure_credentials.call_count == 2
 
     @pytest.mark.asyncio
     async def test_config_credential_error(self):