refactor: Remove redundant nested if block in job-deploy-windows.yml

Prachig-Microsoft · Prachig-Microsoft · commit 6d577b1aee8e · 2026-04-17T18:11:02.000+05:30
The nested if was checking and assigning the same secret value that was just assigned in the else block above it, making it redundant. This was caused by commit de40f53 which unified the secret names, making the original fallback mechanism obsolete.
diff --git a/.github/workflows/job-deploy-windows.yml b/.github/workflows/job-deploy-windows.yml
@@ -271,9 +271,6 @@ jobs:
               $EXP_AI_PROJECT_ID = $env:INPUT_AZURE_EXISTING_AIPROJECT_RESOURCE_ID
             } else {
               $EXP_AI_PROJECT_ID = "${{ secrets.AZURE_ENV_FOUNDRY_PROJECT_ID }}"
-              if (-not $EXP_AI_PROJECT_ID) {
-                $EXP_AI_PROJECT_ID = "${{ secrets.AZURE_ENV_FOUNDRY_PROJECT_ID }}"
-              }
             }
             
             Write-Host "AZURE_ENV_EXISTING_LOG_ANALYTICS_WORKSPACE_RID: $EXP_LOG_ANALYTICS_ID"

Original file line number	Diff line number	Diff line change
`@@ -271,9 +271,6 @@ jobs:`
`271`	`271`	`$EXP_AI_PROJECT_ID = $env:INPUT_AZURE_EXISTING_AIPROJECT_RESOURCE_ID`
`272`	`272`	`} else {`
`273`	`273`	`$EXP_AI_PROJECT_ID = "${{ secrets.AZURE_ENV_FOUNDRY_PROJECT_ID }}"`
`274`		`- if (-not $EXP_AI_PROJECT_ID) {`
`275`		`- $EXP_AI_PROJECT_ID = "${{ secrets.AZURE_ENV_FOUNDRY_PROJECT_ID }}"`
`276`		`- }`
`277`	`274`	`}`
`278`	`275`
`279`	`276`	`Write-Host "AZURE_ENV_EXISTING_LOG_ANALYTICS_WORKSPACE_RID: $EXP_LOG_ANALYTICS_ID"`