Skip to content

Commit 750547f

Browse files
Updated bicep
1 parent 9597e83 commit 750547f

2 files changed

Lines changed: 12 additions & 48 deletions

File tree

infra/main.bicep

Lines changed: 10 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -172,37 +172,31 @@ param vmSize string = 'Standard_D2s_v5'
172172
// These parameters are changed for testing - please reset as part of publication
173173

174174
@description('Optional. The Container Registry hostname where the docker images for the backend are located.')
175-
param backendContainerRegistryHostname string = 'macaetas273cr.azurecr.io'
175+
param backendContainerRegistryHostname string = 'biabcontainerreg.azurecr.io'
176176

177177
@description('Optional. The Container Image Name to deploy on the backend.')
178178
param backendContainerImageName string = 'macaebackend'
179179

180180
@description('Optional. The Container Image Tag to deploy on the backend.')
181-
param backendContainerImageTag string = 'v1.4.0'
181+
param backendContainerImageTag string = 'latest_v4'
182182

183183
@description('Optional. The Container Registry hostname where the docker images for the frontend are located.')
184-
param frontendContainerRegistryHostname string = 'macaetas273cr.azurecr.io'
184+
param frontendContainerRegistryHostname string = 'biabcontainerreg.azurecr.io'
185185

186186
@description('Optional. The Container Image Name to deploy on the frontend.')
187187
param frontendContainerImageName string = 'macaefrontend'
188188

189189
@description('Optional. The Container Image Tag to deploy on the frontend.')
190-
param frontendContainerImageTag string = 'v1.3.0'
190+
param frontendContainerImageTag string = 'latest_v4'
191191

192192
@description('Optional. The Container Registry hostname where the docker images for the MCP are located.')
193-
param MCPContainerRegistryHostname string = 'macaetas273cr.azurecr.io'
193+
param MCPContainerRegistryHostname string = 'biabcontainerreg.azurecr.io'
194194

195195
@description('Optional. The Container Image Name to deploy on the MCP.')
196196
param MCPContainerImageName string = 'macaemcp'
197197

198198
@description('Optional. The Container Image Tag to deploy on the MCP.')
199-
param MCPContainerImageTag string = 'v1.2.0'
200-
201-
@description('Optional. The name of the external ACR to grant AcrPull access to. Derived from the registry hostname.')
202-
param externalAcrName string = split(backendContainerRegistryHostname, '.')[0]
203-
204-
@description('Optional. The resource group containing the external ACR. Required when ACR is in a different resource group.')
205-
param externalAcrResourceGroup string = 'rg-macaetas27-3'
199+
param MCPContainerImageTag string = 'latest_v4'
206200

207201
@description('Optional. Enable/Disable usage telemetry for module.')
208202
param enableTelemetry bool = true
@@ -434,18 +428,6 @@ module userAssignedIdentity 'br/public:avm/res/managed-identity/user-assigned-id
434428
}
435429
}
436430

437-
// ========== ACR Pull Role Assignment ========== //
438-
// Grant the user-assigned identity AcrPull on the external container registry.
439-
var acrRoleTargetRg = !empty(externalAcrResourceGroup) ? externalAcrResourceGroup : resourceGroup().name
440-
module acrPullRole 'modules/acr-pull-role.bicep' = {
441-
name: 'acrPullRoleAssignment-${externalAcrName}'
442-
scope: resourceGroup(acrRoleTargetRg)
443-
params: {
444-
acrName: externalAcrName
445-
principalId: userAssignedIdentity.outputs.principalId
446-
}
447-
}
448-
449431
// ========== Virtual Network ========== //
450432
// WAF best practices for virtual networks: https://learn.microsoft.com/en-us/azure/well-architected/service-guides/virtual-network
451433
// WAF recommendations for networking and connectivity: https://learn.microsoft.com/en-us/azure/well-architected/security/networking
@@ -1344,20 +1326,13 @@ module caeDnsZone 'br/public:avm/res/network/private-dns-zone:0.7.1' = if (enabl
13441326
var containerAppResourceName = 'ca-${solutionSuffix}'
13451327
module containerApp 'br/public:avm/res/app/container-app:0.22.0' = {
13461328
name: take('avm.res.app.container-app.${containerAppResourceName}', 64)
1347-
dependsOn: [acrPullRole]
13481329
params: {
13491330
name: containerAppResourceName
13501331
tags: tags
13511332
location: location
13521333
enableTelemetry: enableTelemetry
13531334
environmentResourceId: containerAppEnvironment.outputs.resourceId
13541335
managedIdentities: { userAssignedResourceIds: [userAssignedIdentity.outputs.resourceId] }
1355-
registries: [
1356-
{
1357-
server: backendContainerRegistryHostname
1358-
identity: userAssignedIdentity.outputs.resourceId
1359-
}
1360-
]
13611336
ingressTargetPort: 8000
13621337
ingressExternal: true
13631338
activeRevisionsMode: 'Single'
@@ -1396,7 +1371,7 @@ module containerApp 'br/public:avm/res/app/container-app:0.22.0' = {
13961371
name: 'backend'
13971372
image: '${backendContainerRegistryHostname}/${backendContainerImageName}:${backendContainerImageTag}'
13981373
resources: {
1399-
cpu: '2.0'
1374+
cpu: 2
14001375
memory: '4.0Gi'
14011376
}
14021377
env: [
@@ -1540,20 +1515,13 @@ module containerApp 'br/public:avm/res/app/container-app:0.22.0' = {
15401515
var containerAppMcpResourceName = 'ca-mcp-${solutionSuffix}'
15411516
module containerAppMcp 'br/public:avm/res/app/container-app:0.22.0' = {
15421517
name: take('avm.res.app.container-app.${containerAppMcpResourceName}', 64)
1543-
dependsOn: [acrPullRole]
15441518
params: {
15451519
name: containerAppMcpResourceName
15461520
tags: tags
15471521
location: location
15481522
enableTelemetry: enableTelemetry
15491523
environmentResourceId: containerAppEnvironment.outputs.resourceId
15501524
managedIdentities: { userAssignedResourceIds: [userAssignedIdentity.outputs.resourceId] }
1551-
registries: [
1552-
{
1553-
server: MCPContainerRegistryHostname
1554-
identity: userAssignedIdentity.outputs.resourceId
1555-
}
1556-
]
15571525
ingressTargetPort: 9000
15581526
ingressExternal: true
15591527
activeRevisionsMode: 'Single'
@@ -1585,7 +1553,7 @@ module containerAppMcp 'br/public:avm/res/app/container-app:0.22.0' = {
15851553
name: 'mcp'
15861554
image: '${MCPContainerRegistryHostname}/${MCPContainerImageName}:${MCPContainerImageTag}'
15871555
resources: {
1588-
cpu: '2.0'
1556+
cpu: 2
15891557
memory: '4.0Gi'
15901558
}
15911559
env: [
@@ -1690,7 +1658,6 @@ module webServerFarm 'br/public:avm/res/web/serverfarm:0.7.0' = {
16901658
var webSiteResourceName = 'app-${solutionSuffix}'
16911659
module webSite 'modules/web-sites.bicep' = {
16921660
name: take('module.web-sites.${webSiteResourceName}', 64)
1693-
dependsOn: [acrPullRole]
16941661
params: {
16951662
name: webSiteResourceName
16961663
tags: tags
@@ -1954,7 +1921,7 @@ module searchServiceOpenAIRole 'modules/search-openai-role.bicep' = {
19541921
scope: resourceGroup(aiFoundryAiServicesSubscriptionId, aiFoundryAiServicesResourceGroupName)
19551922
params: {
19561923
aiFoundryAccountName: aiFoundryAiServicesResourceName
1957-
searchServicePrincipalId: searchServiceIdentity.outputs.systemAssignedMIPrincipalId!
1924+
searchServicePrincipalId: searchServiceUpdate.outputs.systemAssignedMIPrincipalId!
19581925
roleNameGuidSeed: searchServiceName
19591926
}
19601927
}
@@ -1973,9 +1940,6 @@ module aiSearchFoundryConnection 'modules/aifp-connections.bicep' = {
19731940
searchServiceLocation: searchService.location
19741941
searchServiceName: searchService.name
19751942
}
1976-
dependsOn: [
1977-
aiFoundryAiServices
1978-
]
19791943
}
19801944

19811945
// ============ //
@@ -2009,7 +1973,7 @@ output AZURE_AI_PROJECT_NAME string = aiFoundryAiProjectName
20091973
// output AZURE_AI_AGENT_ENDPOINT string = aiFoundryAiProjectEndpoint
20101974
output APP_ENV string = 'Prod'
20111975
output AI_FOUNDRY_RESOURCE_ID string = !useExistingAiFoundryAiProject
2012-
? aiFoundryAiServices.outputs.resourceId
1976+
? aiFoundryAiServices!.outputs.resourceId
20131977
: existingFoundryProjectResourceId
20141978
output COSMOSDB_ACCOUNT_NAME string = cosmosDbResourceName
20151979
output AZURE_SEARCH_ENDPOINT string = searchServiceUpdate.outputs.endpoint

infra/main.parameters.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"value": "${AZURE_ENV_5MINI_MODEL_VERSION}"
5555
},
5656
"gpt5MiniModelDeploymentType": {
57-
"value": "${AZURE_ENV_5MINI_MODEL_DEPLOYMENT_TYPE=latest_v4}"
57+
"value": "${AZURE_ENV_5MINI_MODEL_DEPLOYMENT_TYPE}"
5858
},
5959
"backendContainerImageTag": {
6060
"value": "${AZURE_ENV_IMAGE_TAG=latest_v4}"
@@ -63,7 +63,7 @@
6363
"value": "${AZURE_ENV_5MINI_MODEL_CAPACITY}"
6464
},
6565
"gptImageModelName": {
66-
"value": "${AZURE_ENV_IMAGE_MODEL_NAME=latest_v4}"
66+
"value": "${AZURE_ENV_IMAGE_MODEL_NAME}"
6767
},
6868
"MCPContainerImageTag": {
6969
"value": "${AZURE_ENV_IMAGE_TAG=latest_v4}"

0 commit comments

Comments
 (0)