chore: resolve copilot comments#1005
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses prior Copilot review feedback by aligning backend PlanStatus usage with the persisted Agent Framework models, adding regression tests around orchestration failure handling, and tightening the UI behavior on plan failure.
Changes:
- Update backend orchestration to import
PlanStatusfromcommon.models.messages_afand set failed status using the lowercase enum member. - Add backend tests verifying plan status updates on orchestration exceptions (including DB-update failure behavior and no-plan-id behavior).
- Disable chat input on WebSocket error/failure paths in the Plan UI; minor wording tweak in an infra script log line.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tests/backend/v4/orchestration/test_orchestration_manager.py | Updates mocks for messages_af.PlanStatus and adds new orchestration failure-path tests. |
| src/backend/v4/orchestration/orchestration_manager.py | Switches PlanStatus import source and updates failed-status assignment; adjusts error payload timestamp source. |
| src/App/src/hooks/usePlanWebSocket.tsx | Disables chat input when the plan fails via FINAL_RESULT_MESSAGE error status or ERROR_MESSAGE. |
| infra/scripts/assign_azure_ai_user_role.sh | Updates an echo message to refer to “Foundry resource id”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
May 25, 2026
|
🎉 This PR is included in version 4.2.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addressed the copilot comments which were on dev-v4 to main PR.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information