Skip to content

chore: resolve copilot comments#1005

Merged
Roopan-Microsoft merged 2 commits into
dev-v4from
copilot-comments
May 25, 2026
Merged

chore: resolve copilot comments#1005
Roopan-Microsoft merged 2 commits into
dev-v4from
copilot-comments

Conversation

@Ayaz-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

Addressed the copilot comments which were on dev-v4 to main PR.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
v4/orchestration
   orchestration_manager.py2643188%266–267, 328–330, 334, 340, 352–354, 358, 364, 404–405, 423, 483–484, 491, 493–497, 499–502, 504, 554, 559, 563
TOTAL305538187% 

Tests Skipped Failures Errors Time
886 5 💤 0 ❌ 0 🔥 7.844s ⏱️

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses prior Copilot review feedback by aligning backend PlanStatus usage with the persisted Agent Framework models, adding regression tests around orchestration failure handling, and tightening the UI behavior on plan failure.

Changes:

  • Update backend orchestration to import PlanStatus from common.models.messages_af and set failed status using the lowercase enum member.
  • Add backend tests verifying plan status updates on orchestration exceptions (including DB-update failure behavior and no-plan-id behavior).
  • Disable chat input on WebSocket error/failure paths in the Plan UI; minor wording tweak in an infra script log line.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/tests/backend/v4/orchestration/test_orchestration_manager.py Updates mocks for messages_af.PlanStatus and adds new orchestration failure-path tests.
src/backend/v4/orchestration/orchestration_manager.py Switches PlanStatus import source and updates failed-status assignment; adjusts error payload timestamp source.
src/App/src/hooks/usePlanWebSocket.tsx Disables chat input when the plan fails via FINAL_RESULT_MESSAGE error status or ERROR_MESSAGE.
infra/scripts/assign_azure_ai_user_role.sh Updates an echo message to refer to “Foundry resource id”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/backend/v4/orchestration/orchestration_manager.py Outdated
@Roopan-Microsoft Roopan-Microsoft merged commit 9f7a2fc into dev-v4 May 25, 2026
5 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the copilot-comments branch May 25, 2026 13:26
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants