chore: addressed copilot review comments#1006
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a small piece of the Plan WebSocket hook and adjusts infra role-assignment automation to assign the “Foundry User” role via a dedicated script.
Changes:
- Tweaks how
raw_datais stored for FINAL_RESULT error messages in the Plan WebSocket hook. - Switches
cosmosdb_and_ai_user_role_assignment.shto call a newassign_foundry_user_role.shscript. - Adds
assign_foundry_user_role.shto assign the Foundry User role to provided principals.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/App/src/hooks/usePlanWebSocket.tsx | Minor adjustment to the raw_data value stored for FINAL_RESULT error handling. |
| infra/scripts/cosmosdb_and_ai_user_role_assignment.sh | Calls the new Foundry role assignment script instead of the prior AI user role assignment flow. |
| infra/scripts/assign_foundry_user_role.sh | New script that performs the Foundry User role assignment for a list of principal IDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… managedIdentityClientId parameter
Roopan-Microsoft
approved these changes
May 29, 2026
|
🎉 This PR is included in version 4.2.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addressed and implemented copilot review comment in dev-v4 to main PR
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information