Skip to content

chore: addressed copilot review comments#1006

Merged
Roopan-Microsoft merged 3 commits into
dev-v4from
copilot-comments
May 29, 2026
Merged

chore: addressed copilot review comments#1006
Roopan-Microsoft merged 3 commits into
dev-v4from
copilot-comments

Conversation

@Ayaz-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

Addressed and implemented copilot review comment in dev-v4 to main PR

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates a small piece of the Plan WebSocket hook and adjusts infra role-assignment automation to assign the “Foundry User” role via a dedicated script.

Changes:

  • Tweaks how raw_data is stored for FINAL_RESULT error messages in the Plan WebSocket hook.
  • Switches cosmosdb_and_ai_user_role_assignment.sh to call a new assign_foundry_user_role.sh script.
  • Adds assign_foundry_user_role.sh to assign the Foundry User role to provided principals.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/App/src/hooks/usePlanWebSocket.tsx Minor adjustment to the raw_data value stored for FINAL_RESULT error handling.
infra/scripts/cosmosdb_and_ai_user_role_assignment.sh Calls the new Foundry role assignment script instead of the prior AI user role assignment flow.
infra/scripts/assign_foundry_user_role.sh New script that performs the Foundry User role assignment for a list of principal IDs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/scripts/cosmosdb_and_foundry_user_role_assignment.sh
Comment thread infra/scripts/cosmosdb_and_ai_user_role_assignment.sh Outdated
Copilot AI review requested due to automatic review settings May 26, 2026 04:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@Roopan-Microsoft Roopan-Microsoft merged commit 0c35778 into dev-v4 May 29, 2026
4 checks passed
@Ayaz-Microsoft Ayaz-Microsoft deleted the copilot-comments branch June 1, 2026 05:02
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 4.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants