Skip to content

chore: addressed copilot review comments #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roopan-Microsoft merged 3 commits into from
May 29, 2026
Merged

chore: addressed copilot review comments #1006

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2416ff
add assign_foundry_user_role.sh script for role assignment and update…
Ayaz-Microsoft May 25, 2026
09baa80
refactor: update script calls to use assign_foundry_user_role.sh with…
Ayaz-Microsoft May 25, 2026
5939c83
rename cosmosdb_and_foundry_user_role_assignment.sh
Ayaz-Microsoft May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 infra/scripts/assign_azure_ai_user_role.sh → infra/scripts/assign_foundry_user_role.sh
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions infra/scripts/cosmosdb_and_ai_user_role_assignment.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@ echo "add_cosmosdb_access.sh completed successfully."


# Call add_cosmosdb_access.sh
Comment thread
Ayaz-Microsoft marked this conversation as resolved.
Outdated
echo "Running assign_azure_ai_user_role.sh"
bash infra/scripts/assign_azure_ai_user_role.sh "$resourceGroupName" "$aif_resource_id" "$principal_ids" "$managedIdentityClientId"
echo "Running assign_foundry_user_role.sh"
bash infra/scripts/assign_foundry_user_role.sh "$resourceGroupName" "$aif_resource_id" "$principal_ids" "$managedIdentityClientId"
if [ $? -ne 0 ]; then
echo "Error: assign_azure_ai_user_role.sh failed."
echo "Error: assign_foundry_user_role.sh failed."
exit 1
fi
echo "assign_azure_ai_user_role.sh completed successfully."
echo "assign_foundry_user_role.sh completed successfully."
2 changes: 1 addition & 1 deletion src/App/src/hooks/usePlanWebSocket.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export function usePlanWebSocket({
steps: [],
next_steps: [],
content: formatErrorMessage(errorContent),
raw_data: finalMessage || '',
raw_data: finalMessage,
};
dispatch(addAgentMessage(errorAgent));
dispatch(planFailedFinal());
Expand Down