Skip to content

fix: updated the post deployment script for selected scenario run and WAF and EXP alignment#1015

Merged
TravisHilbert merged 1 commit into
feature/TAS27from
psl-infrachangesForCG
Jun 2, 2026
Merged

fix: updated the post deployment script for selected scenario run and WAF and EXP alignment#1015
TravisHilbert merged 1 commit into
feature/TAS27from
psl-infrachangesForCG

Conversation

@Dhruvkumar-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces improvements to the infrastructure deployment scripts and templates, focusing on making deployments more flexible and maintainable. The main changes include refactoring the role assignment logic for the Search Service, and adding support for filtering which knowledge bases or vector stores to process via a new --only CLI option in the seeding scripts.

Key changes:

Infrastructure deployment improvements:

  • Refactored the assignment of the "Cognitive Services OpenAI User" role to the Search Service's managed identity by moving the logic into a dedicated module (modules/search-openai-role.bicep). This allows deployments to work seamlessly across different resource groups and subscriptions, improving reusability and maintainability. (infra/main.bicep, infra/modules/search-openai-role.bicep) [1] [2]

Seeding script enhancements:

  • Added an optional --only CLI argument to the seed_kb_connections.py, seed_knowledge_bases.py, and seed_vector_stores.py scripts, enabling users to filter and process only specified knowledge bases or vector stores. This makes it easier to target specific resources during development or troubleshooting. (infra/scripts/seed_kb_connections.py, infra/scripts/seed_knowledge_bases.py, infra/scripts/seed_vector_stores.py) [1] [2] [3] [4] [5] [6]

  • Updated the .env loading behavior in the seeding scripts to avoid overriding environment variables set by deployment scripts, ensuring correct precedence and safer configuration management. (infra/scripts/seed_kb_connections.py, infra/scripts/seed_vector_stores.py) [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@TravisHilbert TravisHilbert merged commit 0c91d01 into feature/TAS27 Jun 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants