chore: codeQL fixes#1028
Merged
Roopan-Microsoft merged 7 commits intoJun 17, 2026
Merged
Conversation
Rafi-Mohammad-69
requested review from
Avijit-Microsoft,
Fr4nc3,
Roopan-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates async test cases around task cancellation and async context manager cleanup behavior.
Changes:
- Tweaks cancellation tests to assign the awaited task result to
_insideassertRaises. - Refactors a database async context-manager exception test to run inside a nested async function invoked under
pytest.raises.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/tests/backend/v4/config/test_settings.py | Adjusts how awaited task results are handled in cancellation tests. |
| src/tests/backend/common/database/test_database_base.py | Refactors exception/cleanup test for an async database context manager. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fixed the codeQL issues
Does this introduce a breaking change?