ci: Refactor Docker workflow

[Vamshi-Microsoft]

Purpose

This pull request updates the GitHub Actions workflows related to Docker image building and deployment, primarily to standardize the use of vars.ACR_TEST_LOGIN_SERVER instead of secrets.ACR_TEST_LOGIN_SERVER and to simplify workflow triggers and inputs. The changes aim to improve maintainability and security by using repository variables and streamlining workflow configuration.

Key changes include:

Standardization of Azure Container Registry (ACR) Reference:

• Replaced all usages of secrets.ACR_TEST_LOGIN_SERVER with vars.ACR_TEST_LOGIN_SERVER in the Docker build and deployment workflows, ensuring consistent use of repository variables for the ACR login server across Linux, Windows, and Docker build jobs. [1] [2] [3] [4] [5] [6] [7]

Workflow Configuration and Trigger Simplification:

• Removed unused workflow inputs (trigger_type, build_docker_image) from job-docker-build.yml and instead configured the workflow to be triggered directly by workflow_dispatch. Updated the workflow name for clarity.
• Updated the conditional logic in .github/workflows/deploy-orchestrator.yml to match the new trigger and input handling.

These changes make the workflows easier to maintain and align with best practices for managing sensitive information and workflow triggers.

Does this introduce a breaking change?

• Yes
• No

How to Test

• Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

• Test the code

What to Check

Verify that the following are valid

• ...

Other Information

[Copilot]

Pull request overview

This PR refactors the GitHub Actions Docker build/deploy workflows to standardize Azure Container Registry (ACR) references on repository variables (vars.ACR_TEST_LOGIN_SERVER) and simplifies how the Docker build job is triggered/controlled from the deployment orchestrator.

Changes:

• Updated Docker image tagging and ACR endpoint usage across build/deploy workflows to use vars.ACR_TEST_LOGIN_SERVER instead of secrets.ACR_TEST_LOGIN_SERVER.
• Simplified job-docker-build.yml by removing workflow_call inputs and enabling direct workflow_dispatch, while shifting the “should we build?” gating to the orchestrator.
• Updated deploy-orchestrator.yml reusable workflow invocation accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
.github/workflows/job-docker-build.yml	Removes unused inputs, adds workflow_dispatch, updates ACR login/tagging to use vars.ACR_TEST_LOGIN_SERVER.
.github/workflows/job-deploy-windows.yml	Switches ACR endpoint from secret to repo variable when configuring AZD env.
.github/workflows/job-deploy-linux.yml	Switches ACR endpoint from secret to repo variable when configuring AZD env.
.github/workflows/deploy-orchestrator.yml	Moves docker-build gating to the orchestrator job and removes no-longer-valid inputs passed to the reusable build workflow.

Comments suppressed due to low confidence (1)

.github/workflows/job-docker-build.yml:107

• In the summary step, ACR_NAME=$(echo "${{ vars.ACR_TEST_LOGIN_SERVER }}") actually sets ACR_NAME to the login server, not the registry name. Given the earlier az acr login step uses the registry name, this reuses the same variable name with a different meaning. Rename this to something like ACR_LOGIN_SERVER and reference that in the emitted image URLs.

          ACR_NAME=$(echo "${{ vars.ACR_TEST_LOGIN_SERVER }}")
          echo "## 🐳 Docker Build Job Summary" >> $GITHUB_STEP_SUMMARY
          echo "" >> $GITHUB_STEP_SUMMARY
          echo "| Field | Value |" >> $GITHUB_STEP_SUMMARY
          echo "|-------|--------|" >> $GITHUB_STEP_SUMMARY
          echo "| **Job Status** | ${{ job.status == 'success' && '✅ Success' || '❌ Failed' }} |" >> $GITHUB_STEP_SUMMARY

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.