fix: Bicep fix for Failed Private Endpoint

[Ashwal-Microsoft]

This pull request introduces several important infrastructure and documentation updates to improve deployment reliability, enforce newer tooling requirements, and simplify network configuration management. The most significant changes include raising the minimum required Azure Developer CLI (azd) version, clarifying deployment prerequisites and troubleshooting steps, and refactoring the virtual network and network security group (NSG) logic in the Bicep infrastructure code. Additionally, deployment workflows now add richer resource tagging and timestamping for traceability.

Infrastructure and Bicep refactoring:

• The minimum required azd version is now 1.18.0 (was 1.15.0), enforced in azure.yaml and all documentation references. [1] [2]
• The virtual network and all NSG definitions have been moved from inline in infra/main.bicep to a new module (modules/virtualNetwork.bicep), greatly simplifying main.bicep and centralizing network configuration. NSG modules and related variables are removed from main.bicep.
• Subnet references for resources (e.g., virtual machines) have been updated to use new outputs from the refactored virtual network module.
• The createdBy tag logic is improved to handle cases where userPrincipalName is missing, defaulting to objectId, and a new Type tag is added to distinguish WAF/non-WAF deployments.

Deployment workflow improvements:

• Resource deployments in GitHub Actions (deploy.yml, deploy-waf.yml) now generate and apply a CreatedDate tag with a UTC timestamp, and add other descriptive tags to improve traceability and auditing. [1] [2] [3] [4]

Documentation and troubleshooting enhancements:

• All documentation now clearly states the new minimum azd version (1.18.0), with download links and upgrade reminders in both the README.md and DeploymentGuide.md. [1] [2]
• A new troubleshooting guide (LogAnalyticsReplicationDisable.md) explains how to disable Log Analytics workspace replication before resource deletion, and the deployment guide links to it for users who enable redundancy. [1] [2]
• Minor typo fix in the Azure Portal URL in the troubleshooting steps.

Workflow and environment configuration:

• The Azure template validation workflow is now only manually triggerable (via workflow_dispatch), no longer running on every push to main.
• The AZURE_DEV_COLLECT_TELEMETRY environment variable is now passed to the Azure template validation workflow for improved telemetry handling.

These changes collectively improve deployment clarity, enforce up-to-date tooling, and make network configuration more maintainable and modular.## Purpose

• ...

Does this introduce a breaking change?

• Yes
• No

How to Test

• Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

• Test the code

What to Check

Verify that the following are valid

• ...

Other Information