fix: Code fix to handle replan request#1062
Merged
Merged
Conversation
Roopan-Microsoft
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Code fix to handle replan requests.
Issue
When a user creates a task for the Retail Success Team for the first time, the Magentic orchestrator may not gather sufficient information to confidently complete the task. As a result, it triggers a replanning event during workflow execution.
The replanning event generates a new
MagenticPlanReviewRequest, which was being handled the same way as the initial plan review. Consequently,orchestration_manager.pyinvoked_handle_plan_reviews()again, causing the workflow to pause and wait for user approval a second time.This resulted in the user being redirected back to the "Approve Plan" screen, giving the impression that the workflow had failed, even though the orchestration was still active.
Fix
Introduced a
plan_already_approvedflag to track whether the user has already approved the workflow plan.Workflow
True._handle_plan_reviews()method, which would otherwise:PLAN_APPROVAL_REQUESTto the UI.Benefits
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information