feat: Add historical tagging and use build-push-action for Docker image build and push#187
Merged
Merged
Conversation
…ation and historical tagging
Roopan-Microsoft
approved these changes
May 7, 2025
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
blessing-msft
pushed a commit
that referenced
this pull request
Aug 1, 2025
feat: Add historical tagging and use build-push-action for Docker image build and push
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
.github/workflows/docker-build-and-push.ymlfile to improve the Docker build and push process by introducing historical tagging, modularizing the workflow, and enhancing readability. The most important changes include adding historical tags for Docker images, splitting backend and frontend build steps, and replacing inline shell scripts with reusable GitHub Actions.Workflow improvements:
Historical Tagging for Docker Images: Introduced a
HISTORICAL_TAGenvironment variable that combines the branch-based tag, the current date, and the GitHub run ID to create unique historical tags for Docker images.Modularized Backend and Frontend Builds: Replaced the monolithic Docker build-and-push script with separate steps for backend and frontend builds, using
docker/build-push-action@v6for better modularity and maintainability. Each step now supports conditional pushing based on theTAG.Code simplification:
Removed Redundant Conditions: Simplified the conditional check for logging into Azure Container Registry by removing unnecessary parentheses around the
ifcondition.Added Date Retrieval Step: Added a dedicated step to retrieve the current date and store it in the GitHub Actions output, improving clarity and reusability.## Purpose
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information