refactor: Merging the AVM Waf Standard changes to dev branch#416
Merged
Conversation
…tiple modules and update dependencies in pyproject.toml
…ompliance with Azure standards
…tter clarity and maintainability
- Simplified the output structure in `ai-project.bicep` by directly outputting project name, resource ID, and API endpoint instead of using a separate output type. - Deleted the `ai-services.bicep`, `dependencies.bicep`, and `keyVaultExport.bicep` modules as they are no longer needed. - Introduced a new module `ai-services-model-deployments.bicep` to handle cognitive services account deployments and role assignments. - Updated role assignment handling to utilize built-in role names for better clarity and maintainability.
… update references
…D for clarity and update related references
… clarify AI Project resource ID
…le existing project condition
…ndencies in aiServicesName assignment
…nment by removing conditional check
… subscription ID assignment for existing AI projects
…existingAiFoundryAiProjectResourceId
refactor: consolidate AI Foundry AVM + custom code
feat: Refactor private DNS zone creation and add support for reusing existing Foundry project and Log Analytics workspace
…rk access is enabled for Container App Environment and Web App.
Prajwal-Microsoft
approved these changes
Sep 1, 2025
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
deepammi
pushed a commit
to deepammi/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator
that referenced
this pull request
Dec 7, 2025
refactor: Merging the AVM Waf Standard changes to dev branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Parameter and Workflow Standardization:
solutionName,location,azureAiServiceLocation,gptModelDeploymentType) for consistency and clarity in both.github/workflows/deploy.ymland.github/workflows/deploy-waf.yml, as well as ininfra/main.parameters.json. [1] [2] [3]AI Resource Modularity and New Modules:
ai-services-deployments.bicepto manage Cognitive Services account deployments, including support for batch deployments and role assignments.ai-project.bicepto provision and manage AI Foundry projects as sub-resources of Cognitive Services, with outputs for project name, resource ID, and API endpoint.Parameter File Refactoring:
infra/main.parameters.jsonto remove legacy/unused parameters, align with new naming conventions, and add new parameters for backend/frontend container image tags and AI Foundry project resource IDs. [1] [2] [3]infra/main.waf.parameters.jsonfor WAF-aligned deployments, mirroring the new standardized parameter structure.Feature Enablement and Security:
Most Important Changes:
Parameter and Workflow Standardization
solutionName,location,azureAiServiceLocation,gptModelDeploymentType) and removed deprecated/unused parameters. [1] [2] [3]AI Resource Modularity
infra/modules/ai-services-deployments.bicepto manage Cognitive Services deployments and role assignments, supporting batch deployment and role mapping.infra/modules/ai-project.bicepfor provisioning AI Foundry projects under Cognitive Services, with outputs for integration.Parameter File Refactoring
infra/main.parameters.jsonto align with new conventions, remove legacy parameters, and add support for backend/frontend image tags and AI Foundry project resource IDs. [1] [2] [3]infra/main.waf.parameters.jsonfor WAF deployments, using the new standardized parameter structure.Feature Enablement
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information