Skip to content

fix: Remove Createdby Parameter from deploy.yml and change logic in bicep#520

Merged
Roopan-Microsoft merged 3 commits into
devfrom
psl-removecreatetagfrompipeline
Sep 23, 2025
Merged

fix: Remove Createdby Parameter from deploy.yml and change logic in bicep#520
Roopan-Microsoft merged 3 commits into
devfrom
psl-removecreatetagfrompipeline

Conversation

@NirajC-Microsoft

@NirajC-Microsoft NirajC-Microsoft commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

Purpose

This pull request makes minor adjustments to deployment configuration, specifically around the handling of the createdBy metadata in both the deployment workflow and infrastructure code. The changes improve how the createdBy value is set, making it more robust and context-aware.

Deployment metadata improvements:

  • In .github/workflows/deploy.yml, the createdBy environment variable is no longer set during the deployment job, likely to avoid redundancy or potential confusion.

  • In infra/main.bicep, the logic for setting the createdBy parameter has been improved: it now uses the username if available, otherwise it falls back to the deployer's object ID, ensuring the field is always populated with meaningful information.

  • ...

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit cb448da into dev Sep 23, 2025
9 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-removecreatetagfrompipeline branch September 23, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants