fix: Dev-v3 to main#527
Merged
Merged
Conversation
fix: Update Created by tag logic to dev-v3 branch
fix: added the exp foundry project variables
Roopan-Microsoft
approved these changes
Sep 23, 2025
Avijit-Microsoft
approved these changes
Sep 23, 2025
deepammi
pushed a commit
to deepammi/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator
that referenced
this pull request
Dec 7, 2025
fix: Dev-v3 to main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates how the
createdBytag parameter is set in theinfra/main.bicepandinfra/main_custom.bicepfiles. The main change is to improve the logic for determining the value of thecreatedBytag, making it more robust in cases whereuserPrincipalNamemay not be present.Tagging logic improvements:
createdByparameter to check for the existence ofuserPrincipalNamein thedeployer()object. If present, it uses the username part ofuserPrincipalName; otherwise, it falls back to usingobjectId. This makes the tagging more reliable and avoids empty values whenuserPrincipalNameis not available. (infra/main.bicep, [1];infra/main_custom.bicep, [2]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information