fix: Standardize environment variable naming conventions by Prachig-Microsoft · Pull Request #867 · microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator

Prachig-Microsoft · 2026-03-20T12:13:32Z

Purpose

This pull request updates several GitHub Actions workflow files to standardize and clarify environment variable names related to Azure resources. The changes focus on renaming variables for consistency and clarity, particularly those associated with AI services, Log Analytics, and AI project resources. No logic or functional changes are introduced—only variable names are updated across all affected workflows.

Does this introduce a breaking change?

Yes
No

Golden Path Validation

I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

I have validated the deployment process successfully and all services are running as expected with this change.

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

...

Other Information

- Renamed AZURE_ENV_OPENAI_LOCATION to AZURE_ENV_AI_SERVICE_LOCATION - Renamed AZURE_ENV_MODEL_NAME to AZURE_ENV_GPT_MODEL_NAME - Renamed AZURE_ENV_MODEL_VERSION to AZURE_ENV_GPT_MODEL_VERSION - Renamed AZURE_ENV_MODEL_CAPACITY to AZURE_ENV_GPT_MODEL_CAPACITY - Renamed AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID to AZURE_ENV_LOG_ANALYTICS_WORKSPACE_RID - Renamed AZURE_EXISTING_AI_PROJECT_RESOURCE_ID to AZURE_ENV_FOUNDRY_PROJECT_RID Updated 14 files across workflows, parameter files, scripts, and documentation to maintain consistency throughout the project.

Copilot

Pull request overview

This PR standardizes Azure-related environment variable names across infrastructure parameter files, deployment validation scripts, GitHub Actions workflows, and related documentation to improve consistency and clarity (notably for AI service location, GPT model settings, Log Analytics, and Foundry project resource IDs).

Changes:

Renamed AI service region env var from AZURE_ENV_OPENAI_LOCATION to AZURE_ENV_AI_SERVICE_LOCATION across scripts/workflows/docs.
Renamed GPT model env vars to AZURE_ENV_GPT_MODEL_{NAME,VERSION,CAPACITY} in infra parameter mappings and docs.
Renamed resource ID env vars to *_RID for Log Analytics and Foundry project across workflows, infra parameters, and docs.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
infra/scripts/validate_model_quota.sh	Updates user guidance text to reference `AZURE_ENV_AI_SERVICE_LOCATION`.
infra/scripts/validate_model_quota.ps1	Updates user guidance text to reference `AZURE_ENV_AI_SERVICE_LOCATION`.
infra/main.waf.parameters.json	Maps standardized env var names into WAF deployment parameters.
infra/main.parameters.json	Maps standardized env var names into default deployment parameters.
docs/re-use-log-analytics.md	Updates `azd env set` example to `AZURE_ENV_LOG_ANALYTICS_WORKSPACE_RID`.
docs/re-use-foundry-project.md	Updates `azd env set` example to `AZURE_ENV_FOUNDRY_PROJECT_RID`.
docs/CustomizingAzdParameters.md	Updates parameter table and examples to standardized env var names.
.github/workflows/job-deploy.yml	Renames workflow-call inputs/outputs and internal variables to standardized names.
.github/workflows/job-deploy-windows.yml	Renames reusable workflow inputs/env usage to standardized names.
.github/workflows/job-deploy-linux.yml	Renames reusable workflow inputs/env usage to standardized names.
.github/workflows/job-cleanup-deployment.yml	Updates cleanup workflow inputs/env usage for AI service location rename.
.github/workflows/deploy-v2.yml	Updates dispatch inputs validation and wiring to standardized names.
.github/workflows/deploy-orchestrator.yml	Updates orchestration wiring to standardized names.
.github/workflows/azure-dev.yml	Updates template validation env vars to standardized names.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ramter in workflow

- azure-dev.yml: Fix AZURE_AI_DEPLOYMENT_LOCATION -> AZURE_ENV_AI_SERVICE_LOCATION to match standardized naming - job-deploy-windows.yml: Fix AZURE_ENV_FOUNDRY_PROJECT_ID -> AZURE_ENV_FOUNDRY_PROJECT_RID typo in fallback Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…vention

…aming-standardization

…URE_ENV_AI_SERVICE_LOCATION - Updated azure-dev.yml to use vars.AZURE_AI_DEPLOYMENT_LOCATION instead of secrets.AZURE_ENV_AI_SERVICE_LOCATION - Updated azd-template-validation.yml to map AZURE_AI_DEPLOYMENT_LOCATION to standardized variable name AZURE_ENV_AI_SERVICE_LOCATION - Both workflows now consistently use the existing GitHub repository variable - No changes required to GitHub repository settings

- Changed AZURE_ENV_EXISTING_LOG_ANALYTICS_WORKSPACE_RID back to AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID - Changed AZURE_EXISTING_AIPROJECT_RESOURCE_ID back to AZURE_ENV_FOUNDRY_PROJECT_ID

- Rename virtualMachineSize -> vmSize - Rename virtualMachineAdminUsername -> vmAdminUsername - Rename virtualMachineAdminPassword -> vmAdminPassword - Rename gptModelDeploymentType -> deploymentType - Rename gptModelCapacity -> gptDeploymentCapacity - Rename existingAiFoundryAiProjectResourceId -> existingFoundryProjectResourceId - Rename azureopenaiVersion -> azureOpenaiAPIVersion Updated files: - infra/main.bicep & main_custom.bicep (parameter declarations and references) - infra/main.json (regenerated from Bicep) - infra/main.parameters.json & main.waf.parameters.json (parameter mappings) - .github/workflows/deploy.yml & deploy-waf.yml (workflow parameter passing) All parameter names now consistently map to standardized azd environment variables.

Resolved conflict in infra/main_custom.bicep by keeping standardized parameter name: - Keep: azureOpenaiAPIVersion (standardized naming) - Reject: azureopenaiVersion (old inconsistent naming)

The nested if was checking and assigning the same secret value that was just assigned in the else block above it, making it redundant. This was caused by commit de40f53 which unified the secret names, making the original fallback mechanism obsolete.

…in azd-template-validation.yml Standardize environment variable name to match the convention used in: - azure-dev.yml - main.parameters.json - main.waf.parameters.json - Documentation .

Harsh-Microsoft

LGTM

github-actions · 2026-04-27T05:34:54Z

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Prachig-Microsoft temporarily deployed to production March 20, 2026 12:13 — with GitHub Actions Inactive

Prachig-Microsoft changed the title ~~Standardize environment variable naming conventions~~ fix: Standardize environment variable naming conventions Mar 20, 2026

Prachig-Microsoft requested a review from Copilot March 23, 2026 12:06

Copilot started reviewing on behalf of Prachig-Microsoft March 23, 2026 12:07 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread .github/workflows/job-deploy-linux.yml

Comment thread .github/workflows/job-deploy-linux.yml Outdated

Comment thread .github/workflows/job-deploy-windows.yml

Comment thread docs/CustomizingAzdParameters.md Outdated

Update .github/workflows/job-deploy-linux.yml

e2ea72e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Prachig-Microsoft temporarily deployed to production March 23, 2026 12:14 — with GitHub Actions Inactive

Update .github/workflows/job-deploy-windows.yml

0511ef0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Prachig-Microsoft temporarily deployed to production March 23, 2026 12:15 — with GitHub Actions Inactive

Update resource group creation command to include tags and fix exp pa…

e5b8c39

…ramter in workflow

Vamshi-Microsoft temporarily deployed to production March 26, 2026 08:49 — with GitHub Actions Inactive

Add RG_TAGS environment variable to deployment workflow

a0095aa

Vamshi-Microsoft temporarily deployed to production March 26, 2026 10:00 — with GitHub Actions Inactive

Prachig-Microsoft temporarily deployed to production March 31, 2026 09:19 — with GitHub Actions Inactive

Prachig-Microsoft temporarily deployed to production March 31, 2026 09:20 — with GitHub Actions Inactive

Prachig-Microsoft had a problem deploying to production March 31, 2026 09:28 — with GitHub Actions Failure

Prachig-Microsoft had a problem deploying to production March 31, 2026 11:08 — with GitHub Actions Failure

Prachig-Microsoft temporarily deployed to production April 7, 2026 11:25 — with GitHub Actions Inactive

Prachig-Microsoft added 2 commits April 9, 2026 13:28

Standardize environment variable names - Updated parameter naming con…

1edb473

…vention

Merge remote-tracking branch 'origin/dev-v4' into feature/parameter-n…

fc27cbc

…aming-standardization

Prachig-Microsoft temporarily deployed to production April 9, 2026 12:06 — with GitHub Actions Inactive

Prachig-Microsoft marked this pull request as ready for review April 9, 2026 12:10

Prachig-Microsoft requested review from Avijit-Microsoft, Fr4nc3, Prajwal-Microsoft, Roopan-Microsoft, Vinay-Microsoft and marktayl1 as code owners April 9, 2026 12:10

Prachig-Microsoft requested review from aniaroramsft, dgp10801, nchandhi and toherman-msft as code owners April 9, 2026 12:10

Prachig-Microsoft temporarily deployed to production April 9, 2026 12:10 — with GitHub Actions Inactive

Harsh-Microsoft reviewed Apr 14, 2026

View reviewed changes

Comment thread .github/workflows/azure-dev.yml Outdated

Prachig-Microsoft temporarily deployed to production April 14, 2026 12:03 — with GitHub Actions Inactive

Harsh-Microsoft reviewed Apr 15, 2026

View reviewed changes

Comment thread .github/workflows/job-deploy-linux.yml Outdated

Harsh-Microsoft reviewed Apr 15, 2026

View reviewed changes

Comment thread .github/workflows/job-deploy-linux.yml Outdated

Harsh-Microsoft reviewed Apr 15, 2026

View reviewed changes

Comment thread .github/workflows/job-deploy-windows.yml Outdated

Harsh-Microsoft reviewed Apr 15, 2026

View reviewed changes

Comment thread .github/workflows/job-deploy-windows.yml Outdated

Fix: Revert secret names to match GitHub settings

de40f53

- Changed AZURE_ENV_EXISTING_LOG_ANALYTICS_WORKSPACE_RID back to AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID - Changed AZURE_EXISTING_AIPROJECT_RESOURCE_ID back to AZURE_ENV_FOUNDRY_PROJECT_ID

Prachig-Microsoft temporarily deployed to production April 15, 2026 08:31 — with GitHub Actions Inactive

Prachig-Microsoft added 2 commits April 17, 2026 16:39

Merge origin/dev-v4 into feature/parameter-naming-standardization

1e9f011

Resolved conflict in infra/main_custom.bicep by keeping standardized parameter name: - Keep: azureOpenaiAPIVersion (standardized naming) - Reject: azureopenaiVersion (old inconsistent naming)

Prachig-Microsoft temporarily deployed to production April 17, 2026 12:31 — with GitHub Actions Inactive

Harsh-Microsoft reviewed Apr 17, 2026

View reviewed changes

Comment thread .github/workflows/azd-template-validation.yml Outdated

Prachig-Microsoft added 2 commits April 17, 2026 18:11

fix: Rename AZURE_ENV_MODEL_CAPACITY to AZURE_ENV_GPT_MODEL_CAPACITY …

27e4ea6

…in azd-template-validation.yml Standardize environment variable name to match the convention used in: - azure-dev.yml - main.parameters.json - main.waf.parameters.json - Documentation .

Prachig-Microsoft had a problem deploying to production April 17, 2026 13:13 — with GitHub Actions Failure

Prachig-Microsoft temporarily deployed to production April 17, 2026 13:36 — with GitHub Actions Inactive

Harsh-Microsoft approved these changes Apr 17, 2026

View reviewed changes

Roopan-Microsoft approved these changes Apr 23, 2026

View reviewed changes

Roopan-Microsoft merged commit 68e8a34 into dev-v4 Apr 23, 2026
4 of 5 checks passed

github-actions Bot added the released label Apr 27, 2026

Roopan-Microsoft deleted the feature/parameter-naming-standardization branch May 21, 2026 05:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Standardize environment variable naming conventions#867

fix: Standardize environment variable naming conventions#867
Roopan-Microsoft merged 14 commits into
dev-v4from
feature/parameter-naming-standardization

Prachig-Microsoft commented Mar 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Harsh-Microsoft left a comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Prachig-Microsoft commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Does this introduce a breaking change?

Golden Path Validation

Deployment Validation

How to Test

What to Check

Other Information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Harsh-Microsoft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Prachig-Microsoft commented Mar 20, 2026 •

edited

Loading