fix: code quality issues#960
Merged
Merged
Conversation
Roopan-Microsoft
approved these changes
Apr 29, 2026
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes minor improvements to error handling and code style in both the frontend server and backend test files. The changes focus on making exception handling more robust and clarifying test code by removing unnecessary assignments.
Error handling improvements:
src/App/frontend_server.py, added a comment to clarify that exceptions during websocket cleanup are intentionally ignored, as the websocket may already be closed.Test code cleanup:
src/tests/backend/v4/config/test_settings.py, removed unnecessary variable assignments when awaiting tasks in test cases, improving code clarity and consistency. [1] [2]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information