Skip to content

fix: code quality issues#960

Merged
Roopan-Microsoft merged 1 commit into
dev-v4from
code-quality
Apr 29, 2026
Merged

fix: code quality issues#960
Roopan-Microsoft merged 1 commit into
dev-v4from
code-quality

Conversation

@Kanchan-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request includes minor improvements to error handling and code style in both the frontend server and backend test files. The changes focus on making exception handling more robust and clarifying test code by removing unnecessary assignments.

Error handling improvements:

  • In src/App/frontend_server.py, added a comment to clarify that exceptions during websocket cleanup are intentionally ignored, as the websocket may already be closed.

Test code cleanup:

  • In src/tests/backend/v4/config/test_settings.py, removed unnecessary variable assignments when awaiting tasks in test cases, improving code clarity and consistency. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL303437987% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
883 5 💤 0 ❌ 0 🔥 7.755s ⏱️

@Roopan-Microsoft Roopan-Microsoft merged commit 8a6bd07 into dev-v4 Apr 29, 2026
4 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the code-quality branch April 29, 2026 07:12
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants