Skip to content

fix: Add toaster message of failure in logs#985

Merged
Roopan-Microsoft merged 3 commits into
dev-v4from
psl-fix-43544
May 18, 2026
Merged

fix: Add toaster message of failure in logs#985
Roopan-Microsoft merged 3 commits into
dev-v4from
psl-fix-43544

Conversation

@NirajC-Microsoft

@NirajC-Microsoft NirajC-Microsoft commented May 15, 2026

Copy link
Copy Markdown
Contributor

Purpose

image

This pull request introduces improved error handling for plan orchestration, ensuring that errors are communicated more clearly to users and that the plan status is consistently updated to "FAILED" in both the frontend and backend. The changes affect both the backend orchestration logic and the frontend WebSocket/message handling, providing better feedback and state management when orchestration fails.

Backend error handling and plan status updates:

  • The backend now catches exceptions during orchestration, generates user-friendly error messages based on the error type (e.g., rate limits, timeouts, conflicts), and updates the plan's overall_status to FAILED in the database if a plan ID is present.
  • Error messages are sent to the frontend using the ERROR_MESSAGE WebSocket message type, rather than as a FINAL_RESULT_MESSAGE.
  • The orchestration manager now receives and stores the plan_id for error tracking and database updates. [1] [2] [3]

Frontend error handling and UI updates:

  • The frontend WebSocket hook (usePlanWebSocket) now listens for error statuses in both FINAL_RESULT_MESSAGE and ERROR_MESSAGE types. On error, it displays a user-friendly error message, updates the UI state (e.g., disables spinners, shows toasts), and dispatches the new planFailedFinal action to update the Redux store. [1] [2] [3]
  • A new Redux action, planFailedFinal, is introduced to set the plan status to FAILED and hide processing spinners in the UI. [1] [2]
  • The error-handling code ensures the WebSocket is disconnected after an error, preventing further processing of failed plans. [1] [2]

These changes provide a more robust and user-friendly experience when orchestration errors occur, ensuring the application's state accurately reflects failures and that users receive clear feedback.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
v4/orchestration
   orchestration_manager.py2653985%267–268, 329–331, 335, 341, 353–355, 359, 365, 405–406, 424, 484–485, 492, 494–498, 500–503, 505, 555, 560, 564, 574–581
TOTAL305638987% 

Tests Skipped Failures Errors Time
883 5 💤 0 ❌ 0 🔥 6.917s ⏱️

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings May 18, 2026 11:42

This comment was marked as resolved.

@Roopan-Microsoft Roopan-Microsoft merged commit 6e744e7 into dev-v4 May 18, 2026
8 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-fix-43544 branch May 21, 2026 05:11
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants