Fixes based on code review

Author: darrelmiller

src/Microsoft.OpenApi/Services/OpenApiVisitorBase.cs

@@ -15,20 +15,11 @@ namespace Microsoft.OpenApi.Services
     public abstract class OpenApiVisitorBase
     {
         private readonly Stack<string> _path = new Stack<string>();
-        private CurrentKeys _currentKeys = new CurrentKeys();
-
-
 
         /// <summary>
         /// Properties available to identify context of where an object is within OpenAPI Document
         /// </summary>
-        public CurrentKeys CurrentKeys
-        {
-            get
-            {
-                return _currentKeys;
-            }
-        }
+        public CurrentKeys CurrentKeys { get; } = new CurrentKeys();
 
         /// <summary>
         /// Allow Rule to indicate validation error occured at a deeper context level.  
@@ -58,17 +49,6 @@ public string PathString
             }
         }
 
-        internal void AttachCurrentKeys(CurrentKeys currentKeys)
-        {
-
-        }
-
-        internal void ClearCurrentKeys()
-        {
-
-        }
-    
-
         /// <summary>
         /// Visits <see cref="OpenApiDocument"/>
         /// </summary>

src/Microsoft.OpenApi/Services/OpenApiWalker.cs

@@ -222,8 +222,8 @@ internal void Walk(OpenApiPaths paths)
                 {
                     _visitor.CurrentKeys.Path = pathItem.Key;
                     Walk(pathItem.Key, () => Walk(pathItem.Value));// JSON Pointer uses ~1 as an escape character for /
+                    _visitor.CurrentKeys.Path = null;
                 }
-                _visitor.CurrentKeys.Path = null;
             }
         }
 
@@ -285,8 +285,8 @@ internal void Walk(IOpenApiExtensible openApiExtensible)
                 {
                     _visitor.CurrentKeys.Extension = item.Key;
                     Walk(item.Key, () => Walk(item.Value));
+                    _visitor.CurrentKeys.Extension = null;
                 }
-                _visitor.CurrentKeys.Extension = null;
             }
         }
 
@@ -348,8 +348,8 @@ internal void Walk(OpenApiCallback callback)
                     _visitor.CurrentKeys.Callback = item.Key.ToString();
                     var pathItem = item.Value;
                     Walk(item.Key.ToString(), () => Walk(pathItem));
+                    _visitor.CurrentKeys.Callback = null;
                 }
-                _visitor.CurrentKeys.Callback = null;
             }
         }
 
@@ -401,8 +401,8 @@ internal void Walk(IDictionary<string,OpenApiServerVariable> serverVariables)
                 {
                     _visitor.CurrentKeys.ServerVariable = variable.Key;
                     Walk(variable.Key, () => Walk(variable.Value));
+                    _visitor.CurrentKeys.ServerVariable = null;
                 }
-                _visitor.CurrentKeys.ServerVariable = null;
             }
         }
 
@@ -468,8 +468,8 @@ internal void Walk(IDictionary<OperationType, OpenApiOperation> operations)
                 {
                     _visitor.CurrentKeys.Operation = operation.Key;
                     Walk(operation.Key.GetDisplayName(), () => Walk(operation.Value));
+                    _visitor.CurrentKeys.Operation = null;
                 }
-                _visitor.CurrentKeys.Operation = null;
             }
         }
 
@@ -574,8 +574,8 @@ internal void Walk(OpenApiResponses responses)
                 {
                     _visitor.CurrentKeys.Response = response.Key;
                     Walk(response.Key, () => Walk(response.Value));
+                    _visitor.CurrentKeys.Response = null;
                 }
-                _visitor.CurrentKeys.Response = null;
             }
             Walk(responses as IOpenApiExtensible);
         }
@@ -637,8 +637,8 @@ internal void Walk(IDictionary<string, OpenApiHeader> headers)
                 {
                     _visitor.CurrentKeys.Header = header.Key;
                     Walk(header.Key, () => Walk(header.Value));
+                    _visitor.CurrentKeys.Header = null;
                 }
-                _visitor.CurrentKeys.Header = null;
             }
         }
 
@@ -659,8 +659,8 @@ internal void Walk(IDictionary<string, OpenApiCallback> callbacks)
                 {
                     _visitor.CurrentKeys.Callback = callback.Key;
                     Walk(callback.Key, () => Walk(callback.Value));
+                    _visitor.CurrentKeys.Callback = null;
                 }
-                _visitor.CurrentKeys.Callback = null;
             }
         }
 
@@ -681,8 +681,8 @@ internal void Walk(IDictionary<string, OpenApiMediaType> content)
                 {
                     _visitor.CurrentKeys.Content = mediaType.Key;
                     Walk(mediaType.Key, () => Walk(mediaType.Value));
+                    _visitor.CurrentKeys.Content = null;
                 }
-                _visitor.CurrentKeys.Content = null;
             }
         }
 
@@ -722,8 +722,8 @@ internal void Walk(IDictionary<string, OpenApiEncoding> encodings)
                 {
                     _visitor.CurrentKeys.Encoding = item.Key;
                     Walk(item.Key, () => Walk(item.Value));
+                    _visitor.CurrentKeys.Encoding = null;
                 }
-                _visitor.CurrentKeys.Encoding = null;
             }
         }
 
@@ -810,6 +810,7 @@ internal void Walk(IDictionary<string,OpenApiExample> examples)
                 {
                     _visitor.CurrentKeys.Example = example.Key;
                     Walk(example.Key, () => Walk(example.Value));
+                    _visitor.CurrentKeys.Example = null;
                 }
             }
         }
@@ -928,8 +929,8 @@ internal void Walk(IDictionary<string,OpenApiLink> links)
                 {
                     _visitor.CurrentKeys.Link = item.Key;
                     Walk(item.Key, () => Walk(item.Value));
+                    _visitor.CurrentKeys.Link = null;
                 }
-                _visitor.CurrentKeys.Link = null;
             }
         }
 
@@ -1070,18 +1071,64 @@ private void ExitComponents()
         }
     }
 
+    /// <summary>
+    /// Object containing contextual information based on where the walker is currently referencing in an OpenApiDocument
+    /// </summary>
     public class CurrentKeys
     {
+        /// <summary>
+        /// Current Path key
+        /// </summary>
         public string Path { get; set; }
+
+        /// <summary>
+        /// Current Operation Type
+        /// </summary>
         public OperationType? Operation { get; set; }
+
+        /// <summary>
+        /// Current Response Status Code
+        /// </summary>
         public string Response { get; set; }
+
+        /// <summary>
+        /// Current Content Media Type
+        /// </summary>
         public string Content { get; set; }
+
+        /// <summary>
+        /// Current Callback Key
+        /// </summary>
         public string Callback { get; set; }
+
+        /// <summary>
+        /// Current Link Key
+        /// </summary>
         public string Link { get; set; }
+
+        /// <summary>
+        /// Current Header Key
+        /// </summary>
         public string Header { get; internal set; }
+
+        /// <summary>
+        /// Current Encoding Key
+        /// </summary>
         public string Encoding { get; internal set; }
+
+        /// <summary>
+        /// Current Example Key
+        /// </summary>
         public string Example { get; internal set; }
+
+        /// <summary>
+        /// Current Extension Key
+        /// </summary>
         public string Extension { get; internal set; }
+
+        /// <summary>
+        /// Current ServerVariable
+        /// </summary>
         public string ServerVariable { get; internal set; }
     }
 }